-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tag link #90
Update tag link #90
Conversation
lib/success.js
Outdated
@@ -106,7 +106,7 @@ module.exports = async (pluginConfig, context) => { | |||
type: 'mrkdwn', | |||
text: `:package: *<${repo.URL}|${repo.path}>:* <${ | |||
repo.URL | |||
}/releases/tag/${gitTag}|${gitTag}>` | |||
}/releases/${gitTag}|${gitTag}>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work with GitHub and Bitbucket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you're totally right! I've just made an update to manage Gitlab and Github tag url in your default template.
Nothing changes for Github projects, the tag url is still: ${repo.URL}/releases/tag/${gitTag}
and now for Gitlab projects, the url is: ${repo.URL}/-/releases/${gitTag}
;)
I don't know what's the url for Bitbucket projects but if needed feel free to add a new condition later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great that you have added tests as well! I think this is ready to merge 👍
🎉 This PR is included in version 3.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fix proposal for this issue #82 .