Merge pull request #34 from dimhotepus/pvs-studio-fixes

Fix issues found by PVS-Studio static analyzer #7
juliusfriedman · Nov 27, 2023 · 07a9fd8 · 07a9fd8
2 parents 29a26a6 + 8273bb0
commit 07a9fd8
Show file tree

Hide file tree

Showing 245 changed files with 871 additions and 843 deletions.
diff --git a/Codecs/Audio/Aac/License.txt b/Codecs/Audio/Aac/License.txt
@@ -2,13 +2,13 @@ Managed Media Aggregation `Media.Codecs.Audio.Aac.dll`
 
 Copyright 2014
 
-Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-http://www.apache.org/licenses/LICENSE-2.0
+https://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/Codecs/Audio/AudioBuffer.cs b/Codecs/Audio/AudioBuffer.cs
@@ -26,7 +26,7 @@ namespace Media.Codecs.Audio
 
     /// <summary>
     /// Defines the logic commonly assoicated with all types of Audio samples.
-    /// <see href="http://wiki.multimedia.cx/?title=PCM#Frequency_And_Sample_Rate">The Multimedia Wiki</see>
+    /// <see href="https://wiki.multimedia.cx/?title=PCM#Frequency_And_Sample_Rate">The Multimedia Wiki</see>
     /// </summary>
     public class AudioBuffer : Media.Codec.MediaBuffer
     {

diff --git a/Codecs/Audio/AudioCodec.cs b/Codecs/Audio/AudioCodec.cs
@@ -1,8 +1,8 @@
 #region Copyright
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/Audio/AudioFormat.cs b/Codecs/Audio/AudioFormat.cs
@@ -1,8 +1,8 @@
 #region Copyright
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/Audio/AudioTransformation.cs b/Codecs/Audio/AudioTransformation.cs
@@ -1,8 +1,8 @@
 #region Copyright
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/Audio/License.txt b/Codecs/Audio/License.txt
@@ -2,13 +2,13 @@ Managed Media Aggregation `Media.Codecs.Audio.dll`
 
 Copyright 2014
 
-Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-http://www.apache.org/licenses/LICENSE-2.0
+https://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/Codecs/Audio/WaveFormatId.cs b/Codecs/Audio/WaveFormatId.cs
@@ -1,8 +1,8 @@
 #region Copyright
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/Classes/Transformation.cs b/Codecs/Classes/Transformation.cs
@@ -1,8 +1,8 @@
 #region Copyright
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/DataLayout.cs b/Codecs/DataLayout.cs
@@ -1,8 +1,8 @@
 #region Copyright
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/Image/ColorConversions.cs b/Codecs/Image/ColorConversions.cs
@@ -1,8 +1,8 @@
 #region Copyright
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 
@@ -187,7 +187,7 @@ internal static unsafe void YUV2RGBManaged(byte[] YUVData, byte[] RGBData, int w
             //like this (where Cb = u , Cr = y)
             //Y0 Cb Y1 Cr Y2 Cb Y3 
 
-            /*http://msdn.microsoft.com/en-us/library/ms893078.aspx
+            /*https://learn.microsoft.com/en-us/previous-versions/windows/embedded/ms893078(v=msdn.10)?redirectedfrom=MSDN
              * 
              * C = Y - 16
              D = U - 128
@@ -197,7 +197,7 @@ internal static unsafe void YUV2RGBManaged(byte[] YUVData, byte[] RGBData, int w
              B = clip(( 298 * C + 516 * D           + 128) >> 8)
 
              * here are a whole bunch more formats for doing this...
-             * http://stackoverflow.com/questions/3943779/converting-to-yuv-ycbcr-colour-space-many-versions
+             * https://stackoverflow.com/questions/3943779/converting-to-yuv-ycbcr-colour-space-many-versions
              */
 
 

diff --git a/Codecs/Image/ImageCodec.cs b/Codecs/Image/ImageCodec.cs
@@ -1,8 +1,8 @@
 #region Copyright
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/Image/ImageTransformation.cs b/Codecs/Image/ImageTransformation.cs
@@ -1,8 +1,8 @@
 #region Copyright
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/Image/Jpeg/License.txt b/Codecs/Image/Jpeg/License.txt
@@ -2,13 +2,13 @@ Managed Media Aggregation `Media.Codecs.Video.Jpeg.dll`
 
 Copyright 2014
 
-Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-http://www.apache.org/licenses/LICENSE-2.0
+https://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/Codecs/Image/Jpeg/Markers.cs b/Codecs/Image/Jpeg/Markers.cs
@@ -1,8 +1,8 @@
 #region Copyright
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/Image/License.txt b/Codecs/Image/License.txt
@@ -2,13 +2,13 @@ Managed Media Aggregation `Media.Codecs.Image.dll`
 
 Copyright 2014
 
-Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-http://www.apache.org/licenses/LICENSE-2.0
+https://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/Codecs/Interfaces/ITransformation.cs b/Codecs/Interfaces/ITransformation.cs
@@ -1,8 +1,8 @@
 #region Copyright
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/License.txt b/Codecs/License.txt
@@ -2,13 +2,13 @@ Managed Media Aggregation `Media.Codec.dll`
 
 Copyright 2014
 
-Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-http://www.apache.org/licenses/LICENSE-2.0
+https://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/Codecs/MediaBuffer.cs b/Codecs/MediaBuffer.cs
@@ -1,8 +1,8 @@
 #region Copyright
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/MediaComponent.cs b/Codecs/MediaComponent.cs
@@ -1,8 +1,8 @@
 #region Copyright
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/MediaFormat.cs b/Codecs/MediaFormat.cs
@@ -1,8 +1,8 @@
 #region Copyright
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/Mpeg/AudioDataTransportStream.cs b/Codecs/Mpeg/AudioDataTransportStream.cs
@@ -1,7 +1,7 @@
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 
@@ -43,8 +43,8 @@ public class AudioDataTransportStream : ElementaryStream
     {
         #region Reference
 
-        //http://wiki.multimedia.cx/index.php?title=ADTS
-        //http://iknowu.duckdns.org/files/public/MP4Maker/MP4Maker.htm
+        //https://wiki.multimedia.cx/index.php?title=ADTS
+        //https://github.com/TalAloni/MP4Maker
 
         #endregion
 

diff --git a/Codecs/Mpeg/ElementaryStream.cs b/Codecs/Mpeg/ElementaryStream.cs
@@ -1,7 +1,7 @@
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/Mpeg/License.txt b/Codecs/Mpeg/License.txt
@@ -2,13 +2,13 @@ Managed Media Aggregation `Media.Containers.Mpeg.dll`
 
 Copyright 2014
 
-Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-http://www.apache.org/licenses/LICENSE-2.0
+https://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/Codecs/Mpeg/PacketizedElementaryStreamReader.cs b/Codecs/Mpeg/PacketizedElementaryStreamReader.cs
@@ -1,7 +1,7 @@
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/Mpeg/ProgramStreamReader.cs b/Codecs/Mpeg/ProgramStreamReader.cs
@@ -1,7 +1,7 @@
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 

diff --git a/Codecs/Mpeg/StreamTypes.cs b/Codecs/Mpeg/StreamTypes.cs
@@ -6,7 +6,7 @@ namespace Media.Containers.Mpeg
     /// Describes the various MPEG Stream Types. (ISO13818-2 and compatible)
     /// <see href="http://www.mp4ra.org/object.html">MP4REG</see>
     /// </summary>
-    //http://xhelmboyx.tripod.com/formats/mpeg-layout.txt
+    //https://xhelmboyx.tripod.com/formats/mpeg-layout.txt
     public static class StreamTypes
     {
         public const byte Forbidden = 0x00;

diff --git a/Codecs/Mpeg/TransportStreamReader.cs b/Codecs/Mpeg/TransportStreamReader.cs
@@ -1,7 +1,7 @@
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"), 
@@ -53,7 +53,7 @@ public class TransportStreamReader : Media.Container.MediaFileStream, Media.Cont
 
         //http://basemedia.Codeplex.com
 
-        //http://iknowu.duckdns.org/files/public/MP4Maker/MP4Maker.htm
+        //https://github.com/TalAloni/MP4Maker
 
         #endregion
 

diff --git a/Codecs/Mpeg/VideoStream.cs b/Codecs/Mpeg/VideoStream.cs
@@ -1,7 +1,7 @@
 /*
-This file came from Managed Media Aggregation, You can always find the latest version @ https://net7mma.codeplex.com/
+This file came from Managed Media Aggregation, You can always find the latest version @ https://github.com/juliusfriedman/net7mma_core
   
- Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. http://www.asti-trans.com)
+ Julius.Friedman@gmail.com / (SR. Software Engineer ASTI Transportation Inc. https://www.asti-trans.com)
 
 Permission is hereby granted, free of charge, 
  * to any person obtaining a copy of this software and associated documentation files (the "Software"),