Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very minor bug in RSSM #81

Open
alec-tschantz opened this issue Nov 20, 2020 · 1 comment
Open

Very minor bug in RSSM #81

alec-tschantz opened this issue Nov 20, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@alec-tschantz
Copy link

alec-tschantz commented Nov 20, 2020

Very minor (and I may have misunderstood): I believe the input to the stochastic_prior_model in the RSSMTransition class should be deterministic_size rather than hidden_size (line 76 in rnns.py).

This doesn't cause any errors at the moment as these default to the same value (200). But I see no reason why these have to be the same - one is the hidden size of the RNN, and the other is a generic size for hidden nodes in the model.

@alec-tschantz alec-tschantz added the bug Something isn't working label Nov 20, 2020
@juliusfrost
Copy link
Owner

Thanks for finding this! If you want, you can make a pull request with the small change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants