This repository has been archived by the owner on May 31, 2021. It is now read-only.
separate files for projections #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is common in the JS ecosystem to use dasherized file names & camel-cased identifiers. I adapted the code to this convention. Since this is a breaking change, I bumped the version number to `0.6.0`.
|
Wouldn't it be better (for usability) to move the projections to the main folder? |
It's a matter of taste. Since there's lots of meta files (readme, gitignore) and since there might easily be more projections in the future, I moved them into a directory. |
|
bump. (: I will adapt the location of the projections to your taste (imho it's good like it this). would really like to see |
|
bump. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces single files (e.g.
p/mercator.js) for every projection. This makes bundle sizes smaller and allows to easily add more projections.ccf5000 is a breaking change, so i bumped the version number to
0.6.0.