add suport docker and refresh token #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julz
requested changes
Jun 23, 2021
There was a problem hiding this comment.
Thanks so much for the PR @zhaojizhuang, this is super cool!
zhaojizhuang
force-pushed
the
master
branch
7 times, most recently
from
e611937
to
f6e93ae
Compare
|
@julz Thanks for your review, PR has been updated! |
julz
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
there's a couple small nits it'd be good to fix at some point, but let's get this merged and clean those up in another PR. This is really great, thanks @zhaojizhuang!
| const ( | ||
| RuntimeTypeDocker string = "docker" | ||
| RuntimeTypeContainerd string = "contaienrd" | ||
| RuntimeTypeCriO string = "cri-o" |
| var freezeThaw daemon.FreezeThawer | ||
| switch runtimeType { | ||
| case RuntimeTypeDocker: | ||
| freezeThaw, err = docker.NewDockerService() |
There was a problem hiding this comment.
might be nice to make both methods be called New or Connect so they match. Either way ideally we wouldn't have docker.NewDockerService because it stutters
There was a problem hiding this comment.
Both New sounds like a good idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/kind
Fixes #
Release Note
Docs