Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unncessary getProviderConfigValue("token_endpoint_auth_methods_supported") call? #77

Closed
asmarius opened this issue Mar 10, 2017 · 1 comment

Comments

@asmarius
Copy link
Contributor

I'm wondering about why there is an unused variable in line 481 https://github.com/jumbojett/OpenID-Connect-PHP/blob/master/OpenIDConnectClient.php#L481 of OpenIDConnectClient.php

$token_endpoint_auth_methods_supported = $this->getProviderConfigValue("token_endpoint_auth_methods_supported");

Is it by intention to throw an error if there is no "token_endpoint_auth_methods_supported" config set?

@jumbojett
Copy link
Owner

Good question @asmarius. The variable is definitely not needed. (I think it was a copy from line 509.) I'd like you to get credit for contributing to our project. Would you mind submitting a pull request for this change?

jumbojett added a commit that referenced this issue Nov 6, 2017
@azmeuk azmeuk closed this as completed Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants