After clicking on skip intro, button still appears

[UriSheinman]

So the "show skip button for intro duration" is amazing, but an issue I've been having is that it skips the intro but still shows the button after it's being pressed. Video example below

screen-20240302-202056.mp4

[AbandonedCart]

Does holding down shift and reloading the page help? I haven't seen this personally, so I'm wondering if it is a stale browser cache

[UriSheinman]

Does holding down shift and reloading the page help? I haven't seen this personally, so I'm wondering if it is a stale browser cache

This is in findroid so not really an option

[AbandonedCart]

I'll install it and see what's up

[AbandonedCart]

What are your settings for the plugin skip prompt? (times for how early to display it, how long, and how much intro to play)

[UriSheinman]

[AbandonedCart]

In the video, it looks like every time you click it, it goes back to the end of the intro. If you let it go for 7 seconds, does it disappear?

I have a feeling the timeout is still being applied and I missed removing that.

[UriSheinman]

In the video, it looks like every time you click it, it goes back to the end of the intro. If you let it go for 7 seconds, does it disappear?

No cause the "show for duration of intro" is checked. It does go away eventually it just takes a few secs after the intro is skipped.

[AbandonedCart]

That's what I thought. It's keeping the button up because "technically" it is still playing the intro for a few seconds.

[UriSheinman]

Is there a way to change that? So after the button is pressed it stops showing?

[AbandonedCart]

I'm verifying and then pushing it now

[UriSheinman]

Wdym?

[AbandonedCart]

The plugin will be updated as soon as confirm the fix works.

[AbandonedCart]

#53 fixes this. It is v0.1.13

I hurried this one through, since hitting the button at the end of the intro multiple times will get you stuck in a loop of rewinding.

[UriSheinman]

I don't know if it's a plugin side error but I have been trying to update the plugin for the past hour, but it still reports as ver 0.1.10.0 even tho the version in the plugin folder is 0.1.13.0.


And if it is the latest version it still doesn't work:

screen-20240302-213419.mp4

[AbandonedCart]

That is unusual. It appears to be working now on my end, but I think the .10 you are seeing is the binary version. I didn't update that, so it's still showing the old one.

[UriSheinman]

Anyway the issue still persists so no luck with the fix...

[AbandonedCart]

Did you restart the server and reload the app?

[UriSheinman]

Yes, multiple times.

[AbandonedCart]

Untitled.video.-.Made.with.Clipchamp.mp4

Seems like the issue may be in the app because it works in the browser version after the update, but the app still has a delay before the button disappears.

[UriSheinman]

Untitled.video.-.Made.with.Clipchamp.mp4
Seems like the issue may be in the app because it works in the browser version after the update, but the app still has a delay before the button disappears.

I think this was always the problem... As I said I don't use the desktop app when I do the skip button is fine... Is there a way to fix this from here or should I post it on findroid github?

[AbandonedCart]

I think you're waiting on jarnedemeulemeester/findroid#633

[jumoog]

Untitled.video.-.Made.with.Clipchamp.mp4
Seems like the issue may be in the app because it works in the browser version after the update, but the app still has a delay before the button disappears.

I think this was always the problem... As I said I don't use the desktop app when I do the skip button is fine... Is there a way to fix this from here or should I post it on findroid github?

yes there is a delay in findroid but only 1 second

[AbandonedCart]

A temporary fix would be to set the amount of intro to play as 0

[UriSheinman]

A temporary fix would be to set the amount of intro to play as 0

Ill try

[UriSheinman]

A temporary fix would be to set the amount of intro to play as 0

Doesn't work but I guess it's the best that can be done...

[AbandonedCart]

https://github.com/jarnedemeulemeester/findroid/blob/main/player/video/src/main/java/dev/jdtech/jellyfin/viewmodels/PlayerActivityViewModel.kt#L247-L262

They are determining when the button is displayed on their end. I don't know if there is a check somewhere else, but it's essentially keeping the button visible the entire time the intro is playing. That means if you play 3 seconds of intro after the button is pressed, it will still be visible for that 3 seconds. That's the issue I fixed on our end. They would need to fix it on theirs.

[AbandonedCart]

The PR for skipping credits should improve that overhang a bit. @cd16b was nice enough to include shaving a second off the end to offset the check delay.