Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Skip credits #633

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

feat: Skip credits #633

wants to merge 24 commits into from

Conversation

cd16b
Copy link
Contributor

@cd16b cd16b commented Jan 22, 2024

Add support for jumoog's Intro Skipper v0.1.8 and skipping credits

Keep using the old API for intros, and still support ConfusedPolarBear's Intro Skipper.

fix #620

@cd16b cd16b changed the title Skip credits feat: Skip credits Jan 23, 2024
@Gauvino
Copy link

Gauvino commented Feb 3, 2024

Does this could support https://github.com/endrl/jellyfin-plugin-media-analyzer ?

@cd16b
Copy link
Contributor Author

cd16b commented Feb 3, 2024

Does this could support https://github.com/endrl/jellyfin-plugin-media-analyzer?

This PR only allows skipping credits from Jumoog's Intro Skipper v0.1.8.0, a new release of ConfusedPolarBear's Intro Skipper.
The plugin "endrl/jellyfin-plugin-media-analyzer" needs the segments API, but it is not currently supported by Jellyfin version 10.8.xx. Therefore, we will have to wait at least for Jellyfin 10.9.0.

For more information, please refer to:

@jumoog
Copy link

jumoog commented Mar 1, 2024

I only forked the plugin for myself because ConfusedPolarBear quit. I also left everything as it is so that you only have to change the repo url and everything continues to work.

@AbandonedCart

This comment was marked as resolved.

@cd16b
Copy link
Contributor Author

cd16b commented Mar 3, 2024

Seems silly to submit an entire PR for this, but you want the line above to check the hideSkipPromptAt value - 1. Thought it might be better to suggest throwing it in with yours.

Ok, I've added the - 1, but sometimes the button is still visible for some time due to this:

@AbandonedCart

This comment was marked as resolved.

@AbandonedCart
Copy link

That's a good alternative.

@cd16b
Copy link
Contributor Author

cd16b commented Mar 5, 2024

sometimes the button is still visible

Fixed, if you want to test it let me know if it works.

@jarnedemeulemeester
Copy link
Owner

Okay so I took a quick look at this.

The next version of Findroid will target Jellyfin 10.9 so only jumoog's version will work. Knowing that I would completely migrate to the IntroSkipperSegments API call for both intros and credits. Doing that we would also be able to reuse more code for both intros and credits.
Maybe with some generic SkippableSegment class with an enum property called type of type SkippableSegmentType which can be Intro or Credit.
By doing that we can also store those in a single database table for offline access.

I have not taken a detailed look at the code or the API from jumoog's version but I think reworking the intro skip to something more generic like segment skipping would be ideal.

Also, I have not tested this yet, but I would like to include credit skipping in the next release. But no need to rush this since I have quite some more work to do before the next release 😄

@jumoog
Copy link

jumoog commented Jun 6, 2024

I move the discussion to a issue in my repo: jumoog/intro-skipper#193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support on skipping credits in intro skipper
5 participants