-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Skip credits #633
base: main
Are you sure you want to change the base?
feat: Skip credits #633
Conversation
Does this could support https://github.com/endrl/jellyfin-plugin-media-analyzer ? |
This PR only allows skipping credits from Jumoog's Intro Skipper v0.1.8.0, a new release of ConfusedPolarBear's Intro Skipper. For more information, please refer to: |
I only forked the plugin for myself because ConfusedPolarBear quit. I also left everything as it is so that you only have to change the repo url and everything continues to work. |
This comment was marked as resolved.
This comment was marked as resolved.
Ok, I've added the findroid/player/video/src/main/java/dev/jdtech/jellyfin/viewmodels/PlayerActivityViewModel.kt Line 260 in 0a1582f
|
This comment was marked as resolved.
This comment was marked as resolved.
That's a good alternative. |
Fixed, if you want to test it let me know if it works. |
Okay so I took a quick look at this. The next version of Findroid will target Jellyfin 10.9 so only jumoog's version will work. Knowing that I would completely migrate to the I have not taken a detailed look at the code or the API from jumoog's version but I think reworking the intro skip to something more generic like segment skipping would be ideal. Also, I have not tested this yet, but I would like to include credit skipping in the next release. But no need to rush this since I have quite some more work to do before the next release 😄 |
I changed it from Intro and Credit to a generic FindroidSegment:
Where |
Support for jumoog's Intro Skipper:
Keep using the old API for intros, and still support ConfusedPolarBear's Intro Skipper.fix #620