feat: Skip credits

[cd16b]

Support for jumoog's Intro Skipper:

• FindroidSegment
• Skip Intros
• Skip Credits

Keep using the old API for intros, and still support ConfusedPolarBear's Intro Skipper.

fix #620

[Gauvino]

Does this could support https://github.com/endrl/jellyfin-plugin-media-analyzer ?

[cd16b]

Does this could support https://github.com/endrl/jellyfin-plugin-media-analyzer?

This PR only allows skipping credits from Jumoog's Intro Skipper v0.1.8.0, a new release of ConfusedPolarBear's Intro Skipper.
The plugin "endrl/jellyfin-plugin-media-analyzer" needs the segments API, but it is not currently supported by Jellyfin version 10.8.xx. Therefore, we will have to wait at least for Jellyfin 10.9.0.

For more information, please refer to:

• Replace ConfusedPolarBear's intro-skipper with jellyfin-plugin-media-analyzer #590

[jumoog]

I only forked the plugin for myself because ConfusedPolarBear quit. I also left everything as it is so that you only have to change the repo url and everything continues to work.

[cd16b]

Seems silly to submit an entire PR for this, but you want the line above to check the hideSkipPromptAt value - 1. Thought it might be better to suggest throwing it in with yours.

Ok, I've added the - 1, but sometimes the button is still visible for some time due to this:

findroid/player/video/src/main/java/dev/jdtech/jellyfin/viewmodels/PlayerActivityViewModel.kt

Line 260 in 0a1582f

handler.postDelayed(this, 1000L)

[AbandonedCart]

That's a good alternative.

[cd16b]

sometimes the button is still visible

Fixed, if you want to test it let me know if it works.

[jarnedemeulemeester]

Okay so I took a quick look at this.

The next version of Findroid will target Jellyfin 10.9 so only jumoog's version will work. Knowing that I would completely migrate to the IntroSkipperSegments API call for both intros and credits. Doing that we would also be able to reuse more code for both intros and credits.
Maybe with some generic SkippableSegment class with an enum property called type of type SkippableSegmentType which can be Intro or Credit.
By doing that we can also store those in a single database table for offline access.

I have not taken a detailed look at the code or the API from jumoog's version but I think reworking the intro skip to something more generic like segment skipping would be ideal.

Also, I have not tested this yet, but I would like to include credit skipping in the next release. But no need to rush this since I have quite some more work to do before the next release 😄

[cd16b]

Maybe with some generic SkippableSegment class with an enum property called type of type SkippableSegmentType which can be Intro or Credit.

I changed it from Intro and Credit to a generic FindroidSegment:

FindroidSegment(
            type = String,
            skip = Boolean,
            startTime = Double,
            endTime = Double,
            showAt = Double,
            hideAt =Double,
        )

Where type can be: "intro", "credit", "chapter", or everything else.
The problem is getting it from the Intro Skipper API, so currently the code isn't optimized.
Please let me know if you have any ideas on how to improve it.