-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Css #167
Update Css #167
Conversation
That looks good! Also a fan of em over px for flexibility. |
Should we use the emby-button instead? |
What's the difference? |
emby-button is general purpose button for Jellyfin. paper-icon-button-light is for displaying icons. You can test it here. https://github.com/rlauuzo/intro-skipper/releases/tag/10.9%2Fvtest |
I think the paper one was originally used for the secondary effects. It’s a weird design in general, so a button meant to be a button will almost definitely be better for the purpose. |
Better matches UI style |
Ready, if no one else has feedback. |
Nothing looks out of place, so I've got nothing. I'm not sure if anyone will run into issues dropping all the moz and friends compatibility, but a lot of that is for really old browsers. |
Lgtm |
ready? |
Yeah, but if you merge, you'll probably have to change |
I like the styling of the buttons and I would like the same style for the skip notification messages, so they all share the same design priciples. Is that possible? |
This has nothing to do with this plugin. What you are looking for is called jellyfin theme. Please look at the Jellyfin Forum or List on Githbub |
No description provided.