Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Css #167

Merged
merged 7 commits into from
May 18, 2024
Merged

Update Css #167

merged 7 commits into from
May 18, 2024

Conversation

rlauuzo
Copy link
Collaborator

@rlauuzo rlauuzo commented May 16, 2024

No description provided.

@rlauuzo rlauuzo added the enhancement New feature or request label May 16, 2024
@rlauuzo
Copy link
Collaborator Author

rlauuzo commented May 16, 2024

grafik
grafik

Allows for custom accent color and border radius.

@AbandonedCart
Copy link
Collaborator

AbandonedCart commented May 16, 2024

That looks good! Also a fan of em over px for flexibility.

@rlauuzo
Copy link
Collaborator Author

rlauuzo commented May 17, 2024

Should we use the emby-button instead?

@jumoog
Copy link
Owner

jumoog commented May 17, 2024

What's the difference?

@rlauuzo
Copy link
Collaborator Author

rlauuzo commented May 17, 2024

emby-button is general purpose button for Jellyfin. paper-icon-button-light is for displaying icons. You can test it here. https://github.com/rlauuzo/intro-skipper/releases/tag/10.9%2Fvtest

@AbandonedCart
Copy link
Collaborator

I think the paper one was originally used for the secondary effects. It’s a weird design in general, so a button meant to be a button will almost definitely be better for the purpose.

@jumoog
Copy link
Owner

jumoog commented May 18, 2024

Better matches UI style

@rlauuzo rlauuzo marked this pull request as ready for review May 18, 2024 15:14
@rlauuzo
Copy link
Collaborator Author

rlauuzo commented May 18, 2024

Ready, if no one else has feedback.

@AbandonedCart
Copy link
Collaborator

AbandonedCart commented May 18, 2024

Nothing looks out of place, so I've got nothing.

I'm not sure if anyone will run into issues dropping all the moz and friends compatibility, but a lot of that is for really old browsers.

@jumoog
Copy link
Owner

jumoog commented May 18, 2024

Lgtm

@jumoog
Copy link
Owner

jumoog commented May 18, 2024

ready?

@rlauuzo
Copy link
Collaborator Author

rlauuzo commented May 18, 2024

Yeah, but if you merge, you'll probably have to change document.querySelector("#skipIntro") to document.querySelector("#skipIntro .emby-button") in #170

@jumoog jumoog merged commit fc805da into jumoog:master May 18, 2024
3 checks passed
@barrio5
Copy link

barrio5 commented May 20, 2024

I like the styling of the buttons and I would like the same style for the skip notification messages, so they all share the same design priciples. Is that possible?

@jumoog
Copy link
Owner

jumoog commented May 21, 2024

This has nothing to do with this plugin. What you are looking for is called jellyfin theme. Please look at the Jellyfin Forum or List on Githbub

AbandonedCart pushed a commit to RepoDevil/intro-skipper that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants