refactor item queue

[rlauuzo]

No description provided.

[rlauuzo]

• Adds blacklist check if timestamps are invalid  #177 (comment)
• Removes path restriction from automatic tasks and passes item IDs to the analyzer instead.
• Rewrote ChapterAnalyzer using LINQ.
• ChromaAnalyzer tries to create fingerprints even when only a single episode is provided.

[AbandonedCart]

The path restrictions was a super hacky way about it. Glad to see it go.

[jumoog]

so we can remove PathRestrictions from the config?

[AbandonedCart]

It’s still being used right now, but this PR will make it obsolete

[jumoog]

Yes, that is my point, if it is obsolete we should remove it from the configuration page to avoid confusion.

[AbandonedCart]

It’s not in the configuration page. It’s a silent option. It’s a preference only for the sake of existing across multiple files without needing to be passed.

(It was really hacky)

[jumoog]

Oh yes, I just checked the code. Sorry for the confusion.

[AbandonedCart]

I guess that confirms a question i've always had in the back of my mind. Does anime even have the black frames?

(I always assumed it was so subtle that I just didn't see it)

[rlauuzo]

Animes on Netflix often have a standard anime outro followed by black frames displaying credits for all the languages and dubs.

I've also encountered false positives in shows with a black frame announcing the next episode preview exactly 15 seconds before the end. This also triggers the black frame detection.

[AbandonedCart]

The dreaded originals always have follow-up credits.

[AbandonedCart]

I think this one should be prioritized. A lot of the changes here will drastically improve performance and will also open a lot of potential for improving the automatic scans even further.

[jumoog]

whats a good anime for testing?

[AbandonedCart]

My go to has been Demon Slayer because the first episode of the season always puts the intro at the end . It has an intro, credits, and preview. The intro ends in a splash screen so it's easy to locate.

[jumoog]

tests are still working and code looks good.

LGTM

[Gauvino]

Don't know about the code but been running this PR for 2 days without any problem

[jumoog]

is this ready?

[rlauuzo]

I guess so. I'm not entirely sure what the optimal way is to handle the lists for loading existing fingerprints and other data in the Chromaprint analyzer. That being said, the Chromaprint analyzer has some other areas that could be improved, like the silence detection, which seems a bit pointless in its current implementation. But those refinements are probably best left for another time.

[jumoog]

Yes, I think we can merge it in this form for now and make a new release.