Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip segfaulting test on macos #222

Merged
merged 2 commits into from Sep 8, 2023
Merged

Skip segfaulting test on macos #222

merged 2 commits into from Sep 8, 2023

Conversation

odow
Copy link
Member

@odow odow commented Sep 8, 2023

I remember why I haven't chased this down: I can't reproduce it locally.

x-ref #199

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.37% 🎉

Comparison is base (f495d97) 87.67% compared to head (1f37ab0) 88.05%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   87.67%   88.05%   +0.37%     
==========================================
  Files           2        2              
  Lines         349      360      +11     
==========================================
+ Hits          306      317      +11     
  Misses         43       43              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@odow
Copy link
Member Author

odow commented Sep 8, 2023

That time it was #187. Let's see if skipping fixed things.

@odow odow changed the title WIP: diagnose segfault on macos Skip segfaulting test on macos Sep 8, 2023
@odow odow merged commit 40c4c9f into master Sep 8, 2023
10 checks passed
@odow odow deleted the odow-patch-1 branch September 8, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant