Tidy src/atoms/second_order_cone #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
commented
Jan 10, 2024
| @@ -60,7 +50,8 @@ function rationalnorm(x::AbstractExpr, k::Rational{Int}) | |||
| if row == 1 || col == 1 | |||
| return RationalNormAtom(abs(x), k) | |||
| end | |||
| else | |||
| return RationalNormAtom(x, k) | |||
| # FIXME(odow): what happens if x is a matrix? | |||
There was a problem hiding this comment.
Follow-up later. The function previously returned nothing if x was a complex matrix.
odow
commented
Jan 10, 2024
odow
commented
Jan 10, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #541 +/- ##
==========================================
- Coverage 92.83% 92.71% -0.13%
==========================================
Files 86 86
Lines 5375 5326 -49
==========================================
- Hits 4990 4938 -52
- Misses 385 388 +3 ☔ View full report in Codecov by Sentry. |
Closed
blegat
reviewed
Jan 10, 2024
|
|
||
| ## Create a new variable euc_norm to represent the norm |
There was a problem hiding this comment.
This comment was outdated so I deleted it. The function did not in fact create a new variable euc_norm to represent the norm. I think it mean t, and okay, by reading the function I see it is building [t, x] in SOC. I don't think it needs a comment saying that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-ref #538