remove deprecated AbstractTrees calls #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
=======================================
Coverage 92.13% 92.13%
=======================================
Files 83 83
Lines 5443 5443
=======================================
Hits 5015 5015
Misses 428 428
Continue to review full report at Codecov.
|
odow
approved these changes
May 31, 2022
|
You happy? Minimal changes is good. At some point, Convex needs a new maintainer to go through and tidy up a lot of the package. |
|
Yes, should be all good. |
|
It seems Convex.jl needs a new release to include this change? |
|
@baggepinnen ok, registering v0.15.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently done a major overhaul of AbstractTrees.jl which will be part of the upcoming v0.4 release for that package. Convex.jl is unique in that it is the only registered dependency of AbstractTrees.jl which uses the soon-to-be-deprecated functions
treekindandIndexedTree.It seems that Convex.jl contains a re-implementation of
print_treebecause of a problem that dates back to AbstractTrees.jl v0.2. At first, I completely removed this re-implementation in favor of the current AbstractTrees implementation, but later realized that it has since diverged fromAbstractTrees.print_treeeven in v0.3. In particular, whilemaxdepthhas worked fine for a while, we do not have amaxwidth. There are also some small differences in the exact printed forms.Instead, I've removed the calls to
treekindandIndexedTree. This should be fine for all versions of AbstractTree.jl because these features were very poorly documented and almost never used (which has now been explicitly verified).