improve error handling for arrays in nonlinear expressions (#1373)

* improve error handling for arrays in nonlinear expressions * improve coverage
jump-dev · Jul 24, 2018 · eb7acc6 · eb7acc6
1 parent e88ddaa
commit eb7acc6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/parsenlp.jl b/src/parsenlp.jl
@@ -162,8 +162,8 @@ function parseNLExpr_runtime(m::Model, x::NonlinearParameter, tape, parent, valu
     nothing
 end
 
-function parseNLExpr_runtime(m::Model, x::Vector, tape, parent, values)
-    error("Unexpected vector $x in nonlinear expression. Nonlinear expressions may contain only scalar expressions.")
+function parseNLExpr_runtime(m::Model, x::AbstractArray, tape, parent, values)
+    error("Unexpected array $x in nonlinear expression. Nonlinear expressions may contain only scalar expressions.")
 end
 
 function expression_complexity(ex::Expr)

diff --git a/test/nlp.jl b/test/nlp.jl
@@ -128,6 +128,12 @@
         @test_throws ErrorException @NLexpression(m, sum(x))
     end
 
+    @testset "Error on non-scalar expressions" begin
+        m = Model()
+        x = [1,2,3]
+        @test_throws ErrorException @NLexpression(m, x + 1)
+    end
+
     # Converts the lower-triangular sparse Hessian in MOI format into a dense
     # matrix.
     function dense_hessian(hessian_sparsity, V, n)