Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when plural macro not passed a block #3255

Merged
merged 1 commit into from Feb 28, 2023

Conversation

odow
Copy link
Member

@odow odow commented Feb 28, 2023

Closes #3254

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Base: 98.09% // Head: 98.09% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9d82a6c) compared to base (6329762).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3255   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files          34       34           
  Lines        4663     4664    +1     
=======================================
+ Hits         4574     4575    +1     
  Misses         89       89           
Impacted Files Coverage Δ
src/macros.jl 98.57% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow odow mentioned this pull request Feb 28, 2023
14 tasks
@odow odow merged commit 124e5bb into master Feb 28, 2023
@odow odow deleted the od/plural-error branch February 28, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Improve error if block not provided to plural constraint
2 participants