Remove return type annotions on ConstraintPrimal and ConstraintDual #3381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3381 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 34 34
Lines 4921 4922 +1
=======================================
+ Hits 4826 4827 +1
Misses 95 95
☔ View full report in Codecov by Sentry. |
|
@blegat this will muck up your generic number PRs, but I think it's worth getting this one in first because it's clearly a bug for existing code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests haven't finished locally so there might be some issues. But let's see what happens.
Closes #3380