Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coefficient_type argument to add_bridge and remove_bridge #3394

Merged
merged 6 commits into from May 31, 2023

Conversation

odow
Copy link
Member

@odow odow commented May 28, 2023

Closes #3393

@odow odow requested a review from blegat May 28, 2023 23:41
@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8068620) 98.07% compared to head (1757f01) 98.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3394   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files          34       34           
  Lines        4928     4928           
=======================================
  Hits         4833     4833           
  Misses         95       95           
Impacted Files Coverage Δ
src/JuMP.jl 97.26% <100.00%> (ø)
src/constraints.jl 96.61% <100.00%> (+0.01%) ⬆️
src/optimizer_interface.jl 96.87% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blegat
Copy link
Member

blegat commented May 29, 2023

value_type might be confusing with the value_type we're adding in #3377
In here, it's really the coefficient_type used with MOI.Utilities with functions

@odow odow changed the title Add value_type argument to add_bridge and remove_bridge Add coefficient_type argument to add_bridge and remove_bridge May 29, 2023
@odow
Copy link
Member Author

odow commented May 29, 2023

Updated to coefficient_type.

src/constraints.jl Outdated Show resolved Hide resolved
@odow odow requested a review from blegat May 31, 2023 01:33
@odow odow merged commit 8723755 into master May 31, 2023
12 checks passed
@odow odow deleted the od/bridge-value-type branch May 31, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Bridges parametrized by complex type
2 participants