Clean up JuMP.Model. #1383
Clean up JuMP.Model. #1383
Conversation
|
Need to rebase on top of #1362 |
This comment has been minimized.
This comment has been minimized.
|
Rebase done. |
src/JuMP.jl
Outdated
| # Model | ||
| ################################################################################ | ||
| # Model. | ||
| # TODO(IainNZ): Clarify the three keyword arguments. `mode` is explained, |
There was a problem hiding this comment.
This is being refactored in #1384
There was a problem hiding this comment.
Should hold off merging this for now or quickly get it in and build from it?
There was a problem hiding this comment.
Could you revert the docstring for Model and the TODO right here that's going to be out of date? Everything else seems fine.
| """ | ||
| objectivevalue(m::Model) = MOI.get(m, MOI.ObjectiveValue()) | ||
| objectivevalue(model::Model) = MOI.get(model, MOI.ObjectiveValue()) |
There was a problem hiding this comment.
We haven't yet moved over the naming discussion to the style guide, but what do you think about objective_value etc for these?
There was a problem hiding this comment.
I'm a fan of underscores (another difference from Base, but w/e...), so sgtm
There was a problem hiding this comment.
Let's hold off on renaming until we resolve the style question, otherwise it might just be unnecessary churn.
Remove unused fields, style guide, initial attempts to document from an outsiders perspective - very much WIP. Also an attempt to start matching TODOs with issues/people.
|
Done |
Remove unused fields, style guide, initial attempts to document from
an outsiders perspective - very much WIP.
Also an attempt to start matching TODOs with issues/people.