Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a version of method delete that deletes a vector of variables. #2135

Merged
merged 9 commits into from Jan 12, 2020
Merged

Create a version of method delete that deletes a vector of variables. #2135

merged 9 commits into from Jan 12, 2020

Commits on Jan 8, 2020

  1. Create a version of method delete that deletes a vector of variables.… 

    … This calls the version of MOI.delete that also works over a vector of variables, and is specialized by solvers for greater performance than repeteadely calling the single variable version.
    @henriquebecker91
    henriquebecker91 committed Jan 8, 2020
    Copy the full SHA
    e93f147 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2020

  1. Added tests for batch deletion of variables.

    @henriquebecker91
    henriquebecker91 committed Jan 9, 2020
    Copy the full SHA
    873a70f View commit details
    Browse the repository at this point in the history

  2. Adapted the batch deletion test to be executed over JuMPExtension too… 

    …. Implemented the batch deletion in JuMPExtension to pass the test. Increased the coverage of the test to include the cases a Exception is thrown (bad paths).
    @henriquebecker91
    henriquebecker91 committed Jan 9, 2020
    Copy the full SHA
    6cff1ff View commit details
    Browse the repository at this point in the history

  3. Three small fixes/enhancements suggested by @mlubin.

    @henriquebecker91
    henriquebecker91 committed Jan 9, 2020
    Copy the full SHA
    400485b View commit details
    Browse the repository at this point in the history

  4. Fixed two small typos.

    @henriquebecker91
    henriquebecker91 committed Jan 9, 2020
    Copy the full SHA
    16cc11c View commit details
    Browse the repository at this point in the history

  5. Implemented trivial fallback for method that deletes multiple constra… 

    …ints. JuMPExtension implementation and the tests for both JuMP and JuMPExtensions were also added.
    @henriquebecker91
    henriquebecker91 committed Jan 9, 2020
    Copy the full SHA
    6bca6ee View commit details
    Browse the repository at this point in the history

  6. Changed the multiple constraint deletion method to call the MOI fallb… 

    …ack as @odow noted. Ran the tests, code is working.
    @henriquebecker91
    henriquebecker91 committed Jan 9, 2020
    Copy the full SHA
    306a08a View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2020

  1. Changes in the documentation asked by @mlubin.

    @henriquebecker91
    henriquebecker91 committed Jan 12, 2020
    2
    Copy the full SHA
    ee28da2 View commit details
    Browse the repository at this point in the history

  2. Enhancing documentation by giving a one-liner for the user to check i… 

    …f this is the case.
    @henriquebecker91
    henriquebecker91 committed Jan 12, 2020
    Copy the full SHA
    30d6589 View commit details
    Browse the repository at this point in the history