Embed browser_windows in hcl config file

[danielehc]

Current Behavior

Currently it is possible to configure the blueprint by adding a browser_windows section in the .yard file.

browser_windows = [
  "http://localhost:18443",
  "http://localhost:18500",
]

This works fine in cases where the blueprint is created for a complete scenario (aka all applications that need to be exposed are started with the first shipyard run ...).

Extended behavior
I'd like a way to configure the browser_windows behavior inside the ingress object:

• Example syntax 1

ingress "consul-ui" {
  target = "k8s_cluster.k8s"
  service  = "svc/hashicorp-consul-ui"
  
  # Defines whether to honor the `browser_window` param or not
  headless = true
  # Defines URL to open in browser after ingress is created
  browser_window = "http://localhost:18500"
    
  network  {
    name = "network.local"
  }

  port {
    local  = 80
    remote = 80
    host   = 18500
  }
}

• Example syntax 2

ingress "consul-ui" {
  target = "k8s_cluster.k8s"
  service  = "svc/hashicorp-consul-ui"
  
  # can be honored globally by `shipyard` config
  # local_env could potentially be expanded for new feature that leverage desktop integration
  local_env  {
    # Defines whether to honor the `browser_window` param or not
    # headless = true # having this too here might be an overkill

    # Defines URL to open in browser after ingress is created
    browser_window = "http://localhost:18500"
  }
  
    
  network  {
    name = "network.local"
  }

  port {
    local  = 80
    remote = 80
    host   = 18500
  }
}

[danielehc]

Seems also related to #42

[nicholasjackson]

I like this, sometimes you might not want to create a yard file or you might want to do an incremental apply. We added --no-browser to a recent release. I wonder if this satisfies the headless parameter @danielehc ?

[danielehc]

The --no-browser param is fine for all the use cases I can think, so that would be enough.