Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress refactor #60

Merged
merged 7 commits into from
Apr 3, 2020
Merged

Ingress refactor #60

merged 7 commits into from
Apr 3, 2020

Conversation

nicholasjackson
Copy link
Contributor

Changelog:

  • Added ability to open browser windows to ingress, containers, docs
  • Defined three specific ingress resources, nomad_ingress, container_ingress, k8s_ingress for now ingress is backward compatible
  • Only open browser windows if they have not been opened
  • Can now do shipyard run or shipyard run . and this equals shipyard run ./
  • Sidebar configuration is now optional in docs
  • Changed names of Docker resources and FQDN for resources to [name].[type].shipyard.run
  • Resources are now resolvable via DNS
  • Added interpolation helper ${home()} to resolve the home folder from config
  • Added interpolation helper ${shipyard()} to resolve the shipyard folder from config

Fixes

  • Fix serialisation of blueprint in state
  • Fix bug with rolled back resources being in an inconsistent state

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #60 into master will decrease coverage by 1.44%.
The diff coverage is 52.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   60.77%   59.32%   -1.45%     
==========================================
  Files          59       62       +3     
  Lines        2511     2707     +196     
==========================================
+ Hits         1526     1606      +80     
- Misses        828      933     +105     
- Partials      157      168      +11     
Impacted Files Coverage Δ
pkg/config/blueprint.go 66.66% <ø> (ø)
pkg/config/container.go 50.00% <ø> (ø)
pkg/config/docs.go 100.00% <ø> (ø)
pkg/config/helm.go 100.00% <ø> (ø)
pkg/config/ingress.go 100.00% <ø> (ø)
pkg/config/k8s_config.go 50.00% <ø> (ø)
pkg/config/nomad_ingress.go 0.00% <0.00%> (ø)
pkg/config/nomad_job.go 0.00% <ø> (ø)
pkg/providers/container.go 79.41% <0.00%> (ø)
pkg/providers/nomad_job.go 27.65% <0.00%> (-1.23%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1435db7...2470e8a. Read the comment docs.

@nicholasjackson nicholasjackson merged commit 7ef1412 into master Apr 3, 2020
@nicholasjackson nicholasjackson deleted the ingress_refactor branch November 1, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nomad Ingress Embed browser_windows in hcl config file Refactor Ingress Resources
1 participant