Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ACF Extended Pro #44

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

mcaskill
Copy link
Contributor

@mcaskill mcaskill commented Jan 17, 2023

Checklist

Description

Adds support for ACF Extended Pro which uses Easy Digital Downloads.

How has this been tested?

I'm testing this on a client project that uses Advanced Custom Fields Pro, ACF Extended Pro, and WPML.

Types of changes

  • Added class AcfExtendedPro, based on PolylangPro, for fetching its EDD download URL.
  • Added package junaidbhura/acf-extended-pro to Installer::getDownloadUrl().
  • Added references to the README.md.

@mcaskill
Copy link
Contributor Author

I might rename ACF_EXTENDED_PRO_* environment variables to ACFE_PRO_* given that's what the plugin uses in its global constants.

Renamed:
- `ACF_EXTENDED_PRO_KEY` → `ACFE_PRO_KEY `
- `ACF_EXTENDED_PRO_URL ` → `ACFE_PRO_URL `
@junaidbhura junaidbhura merged commit 441bdc5 into junaidbhura:master Jan 23, 2023
@mcaskill mcaskill deleted the feature/acf-extended-pro branch January 23, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants