Chrome tab not closing properly when using Nodemon

[ebramanti]

I have an issue where restarting my server through Nodemon does not close the tab, but instead renders this error message:

After looking through the source code I think I've isolated the problem to here. The catch for the HTTP request does not consider a valid case where the debug server is not down, but the ID of the debugger websocket changes.

A proposed solution would be to store the unique identifier for each devtools session, and check if that identifier is in the returned JSON from the localhost debug server. Requests coulda also be minimized by making the request only once and filtering $scope.devToolsSessions according to the returned identifiers.

I'd be willing to PR this in the next couple days with your OK @june07

Edit: Initial conversation about this issue can be found here.

[june07]

First of all, good work on the detail provided thus far. Thank you. Can you tell me more about your dev environment, including Node version. I'm trying to understand "where the debug server is not down, but the ID of the debugger websocket changes." I havent seen this behavior? Why/how is the websocket changing without a restart of the debugger/node process?

…

On Dec 18, 2016 1:06 AM, "Edward Bramanti" ***@***.***> wrote: I have an issue where restarting my server through Nodemon does not close the tab, but instead renders this error message: [image: screenshot 2016-12-17 21 19 28] <https://cloud.githubusercontent.com/assets/1921464/21292539/c9f6403a-c4bd-11e6-9ca8-5103d0c02992.png> After looking through the source code I think I've isolated the problem to here <https://github.com/june07/NIM/blob/master/background.js#L88-L113>. The catch for the HTTP request does not consider a valid case where the debug server is not down, but the ID of the debugger websocket changes. A proposed solution would be to store the unique identifier for each devtools session, and check if that identifier is in the returned JSON from the localhost debug server. Requests coulda lso be minimized by making the request only once and filtering $scope.devToolsSessions according to the returned identifiers. I'd be willing to PR this in the next couple days with your OK @june07 <https://github.com/june07> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK099m5GSM2DSR_A__-aTWXJvJSbCrfRks5rJPeegaJpZM4LQFWn> .

[ebramanti]

@june07 Dev environment is Node 6.9.1, I'm using [fly] and [fly-nodemon] to run Nodemon, and I pass inspect in as a nodeArgs option to Nodemon. Since the Fly process continues running the server hosting the websockets comes back up before the 3000ms check, I think that could be why your code is not detecting a change.

It might be easier if I show you in code... I have a PR ready that shows the solution I have in mind.

[june07]

Edward, Nice. That's it! I've merged the PR.

…

On Dec 18, 2016 3:37 PM, "Edward Bramanti" ***@***.***> wrote: @june07 <https://github.com/june07> Dev environment is Node 6.9.1, I'm using [fly] and [fly-nodemon] to run Nodemon, and I pass inspect in as a nodeArgs option to Nodemon. Since the Fly process continues running the server hosting the websockets comes back up before the 3000ms check, I think that could be why your code is not detecting a change. It might be easier if I show you in code... I have a PR ready that shows the solution I have in mind. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK099pS8eoW2Po0EJ-fFBQB_gyPFINrwks5rJcPAgaJpZM4LQFWn> .

[ebramanti]

Thanks @june07, let me know when you update this on the Chrome Web Store.

[june07]

The current version is 0.9.0. Do you have the setting on manual or auto? Also how is the auto close setting configured? On Dec 25, 2016 10:57 PM, "Darryl Dexter" <notifications@github.com> wrote: I'm having the same issue, is the new update pushed? When i start my server, i have to goto the url manually, and when nodemon restarts from change, I just get the error. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK099rgHCApOmO1DskIiSAsETOlILt-Wks5rL2VdgaJpZM4LQFWn> .

[DarrylD]

Sorry, commented before I worked it out. Needed to update chrome apparently... Thx, awesome plugin!

[june07]

No worries. Glad to help. And thank you for the positive feedback! If it's not too much trouble, a review and/or rating at the Web Store would help out greatly. On Dec 25, 2016 11:31 PM, "Darryl Dexter" <notifications@github.com> wrote: Sorry, commented before I worked it out. Needed to update chrome apparently... Thx, awesome plugin! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK099lT6OEK2n48hjRPQEp_l-l9uecPcks5rL21WgaJpZM4LQFWn> .

[duanjun]

macOS sierra 10.12.2 . chrome 55.0.2883.95 (64-bit)
had the same problem

[june07]

Are you using the current version? Any additional information you can provide will be helpful in figuring out what is going on. I'm sure you have already but in case not, please read through the entire thread as some information may be helpful.

[duanjun]

it works now . thanks.
maybe my setting is not right !