validate_layout() does not take --reverse into account.

[mrbiggfoot]

• Category
  • Question
  • Bug
  • Suggestion
• OS
  • Linux
  • macOS
  • Windows
  • Etc.
• Vim
  • Vim
  • Neovim

:echo g:fzf_layout
{'options': '--reverse', 'down': '~40%'}

:History
Error detected while processing function <SNR>16_history[7]..fzf#vim#history[1]..<SNR>50_fzf[18]..<SNR>50_wrap[8]..fzf#wrap[30]..<SNR>15_validate_layout:
line    3:
E605: Exception not caught: Invalid entry in g:fzf_layout: options (allowed: window, up, down, left, right). Use $FZF_DEFAULT_OPTS.
Error detected while processing function <SNR>16_history[7]..fzf#vim#history[1]..<SNR>50_fzf[18]..<SNR>50_wrap[8]..fzf#wrap:
line   30:
E171: Missing :endif
Error detected while processing function <SNR>16_history[7]..fzf#vim#history[1]..<SNR>50_fzf[18]..<SNR>50_wrap:
line    8:
E171: Missing :endif
Error detected while processing function <SNR>16_history:
line    7:
E171: Missing :endif

[mrbiggfoot]

Looks like it has stopped accepting --reverse as a valid option. Why is that?

[mrbiggfoot]

Offending commit id: 111d1934c49ac22cf84abf0ada9c24f091fc38cd

[junegunn]

Duplicate of #317 and #327. g:fzf_layout was never designed to take options key. Where did you get the idea? People were misusing it and running into all kinds of problems, so I explicitly disallowed it.

[mrbiggfoot]

@junegunn how do I get --reverse behavior in the History window then?

[mrbiggfoot]

Checked out the other two tickets. Will try $FZF_DEFAULT_OPTS way.

[junegunn]

It seems to me that all you guys ended up with more or less the same type of misconfiguration. Did someone suggest the idea?

[mrbiggfoot]

I wish I could remember... I must have googled it somewhere.

…

On Mon, Mar 20, 2017 at 6:42 PM, Junegunn Choi ***@***.***> wrote: It seems to me that all you guys ended up with more or less the same type of misconfiguration. Did someone suggested the idea? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#341 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALnIiM_0qjJnOidCowvAS-tPU180zuXxks5rnysVgaJpZM4Mi92h> .

[mrbiggfoot]

Though I must admit neither way seems elegant to me. I'd prefer to have a function call that takes a dictionary of arguments for position, orientation, key mappings, etc. Setting g:fzf_layout or $FZF_DEFAULT_OPTS is cumbersome. Anyway, I've worked around it. Thanks for fzf @junegunn!

[junegunn]

Well, you can do that if you want.
See https://github.com/junegunn/fzf.vim#advanced-customization