Use fnamemodify in Cygwin for Windows paths

[janlazo]

From initial testing, only Files and GFiles require fnamemodify.

I can't test Locate in cygwin because it requires updatedb and locate needs a regularly updated database. Windows has its own indexing for explorer.exe but I disabled it in my system for performance. I'll revist it in #372

[junegunn]

Thanks, this makes me wonder, would it make sense to do :p expansion inside fzf#run?

[janlazo]

Sure, since it simplifies FZF and s:get_git_root will not require fnamemodify if fugitive is unavailable.

I see dict.dir handled in fzf#run
I don't know why there's a has('nvim') condition.

[janlazo]

Need fnamemodify only if dict.dir exists.
getcwd always returns a unix-style path in cygwin vim.

[junegunn]

It's only for the cases where dir is not given and it's not related to the current issue. You can always git blame on that :)

junegunn/fzf@cd59e5d

Let's just make sure that we're on the same page. :p expansion is only needed on Cygwin to handle network drives, and the following patch on the main repo should do, right?

diff --git a/plugin/fzf.vim b/plugin/fzf.vim
index 99fda1f..64e8cd3 100644
--- a/plugin/fzf.vim
+++ b/plugin/fzf.vim
@@ -360,6 +360,8 @@ try
 
   if has('nvim') && !has_key(dict, 'dir')
     let dict.dir = s:fzf_getcwd()
+  elseif has('win32unix')
+    let dict.dir = fnamemodify(dir, ':p')
   endif
 
   if !has_key(dict, 'source') && !empty($FZF_DEFAULT_COMMAND)
@@ -765,8 +767,6 @@ function! s:cmd(bang, ...) abort
     let opts.dir = substitute(substitute(remove(args, -1), '\\\(["'']\)', '\1', 'g'), '[/\\]*$', '/', '')
     if s:is_win && !&shellslash
       let opts.dir = substitute(opts.dir, '/', '\\', 'g')
-    elseif has('win32unix')
-      let opts.dir = fnamemodify(opts.dir, ':p')
     endif
     let prompt = opts.dir
   else

[junegunn]

By the way, I wonder if neovim runs on cygwin.

[junegunn]

fixup.

diff --git a/plugin/fzf.vim b/plugin/fzf.vim
index 99fda1f..bad7449 100644
--- a/plugin/fzf.vim
+++ b/plugin/fzf.vim
@@ -361,6 +361,9 @@ try
   if has('nvim') && !has_key(dict, 'dir')
     let dict.dir = s:fzf_getcwd()
   endif
+  if has('win32unix') && has_key(dict, 'dir')
+    let dict.dir = fnamemodify(dict.dir, ':p')
+  endif
 
   if !has_key(dict, 'source') && !empty($FZF_DEFAULT_COMMAND)
     let temps.source = s:fzf_tempname().(s:is_win ? '.bat' : '')
@@ -765,8 +768,6 @@ function! s:cmd(bang, ...) abort
     let opts.dir = substitute(substitute(remove(args, -1), '\\\(["'']\)', '\1', 'g'), '[/\\]*$', '/', '')
     if s:is_win && !&shellslash
       let opts.dir = substitute(opts.dir, '/', '\\', 'g')
-    elseif has('win32unix')
-      let opts.dir = fnamemodify(opts.dir, ':p')
     endif
     let prompt = opts.dir
   else

[janlazo]

Thanks for the reminder. I use vim-rooter so thanks for the patch :)
I'm fine with the patch but need to test the prompt.

By the way, I wonder if neovim runs on cygwin.

It does if you don't use mintty.

[janlazo]

The prompt works for me and is better for me because if I pass a Windows-style path to FZF, I expect the same style in the prompt.

[junegunn]

Okay, thanks for the feedback. Let me push the fix.

[janlazo]

Thanks.