-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable path conversion for Git Bash #1983
Labels
Comments
10 tasks
While |
Konfekt
added a commit
to Konfekt/fzf
that referenced
this issue
May 15, 2024
Despite its title 'Calling fzf#run with a list as source fail (n)vim is used from git bash' the issue in junegunn#3777 of running `:FZF` in Vim in Git Bash was apparently only fixed for Neovim in Git Bash on Windows 11, but not for Vim from Git Bash. In view of this, replacing /C by ///C might be considered a universal fix. This PR just proposes the patch in junegunn#1983 that still seems open. In view of the fourth item in the most recent 2.45.0 https://github.com/git-for-windows/build-extra/blob/main/ReleaseNotes.md#known-issues little seems to have changed regarding path conversion of arguments containing forward slashes
junegunn
pushed a commit
that referenced
this issue
May 15, 2024
* make :FZF work in Vim from Git Bash Despite its title 'Calling fzf#run with a list as source fail (n)vim is used from git bash' the issue in #3777 of running `:FZF` in Vim in Git Bash was apparently only fixed for Neovim in Git Bash on Windows 11, but not for Vim from Git Bash. In view of this, replacing /C by ///C might be considered a universal fix. This PR just proposes the patch in #1983 that still seems open. In view of the fourth item in the most recent 2.45.0 https://github.com/git-for-windows/build-extra/blob/main/ReleaseNotes.md#known-issues little seems to have changed regarding path conversion of arguments containing forward slashes * prefer doubling slashed instead of generic env. var If MSYS_NO_PATHCONV=1 is used, then all arguments are preserved, in particular possibly paths passed in s:command. Therefore, only avoid converting `/C` from `cmd` to a path.
Fixed in #3798 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
man fzf
)Info
Problem / Steps to reproduce
It's the vim integration.
:FZF<CR>
in Vimcmd.exe
is started, and the window for vim itself would entercmd.exe
.Seems the bash contained in Git for Windows is tranlating the
/C
arg forcmd.exe
as a path (probably toC:\
). The following patch would help (according to this)The text was updated successfully, but these errors were encountered: