Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete clearing of the preview window in the presence of combining Unicode characters #2163

Closed
5 of 10 tasks
vejkse opened this issue Sep 1, 2020 · 2 comments
Closed
5 of 10 tasks
Labels

Comments

@vejkse
Copy link

vejkse commented Sep 1, 2020

  • I have read through the manual page (man fzf)
  • I have the latest version of fzf
  • I have searched through the existing issues

Info

  • OS
    • Linux
    • Mac OS X
    • Windows
    • Etc.
  • Shell
    • bash
    • zsh
    • fish

Problem / Steps to reproduce

Here’s the content of a very small text file, let’s call it combining_unicode.txt, where the « ă » is an « a » followed by a combining breve (U+0306):

xyz
ăb
uvw
ab

If I do cat combining_unicode.txt | fzf --preview='echo {}', and move up in the list from xyz to ăb (or type a, so that xyz is filtered out), the preview window shows ăbz instead of ab, the z being the remains of xyz incompletely cleared from the screen. No such problem arises further up when moving from uvw to ab.

This may be related to #1526.

@junegunn junegunn added the bug label Sep 6, 2020
@junegunn
Copy link
Owner

While 69dffd7 is not a proper fix to the problem, it fixes this particular case. Please let me know if you run into another similar issue.

@vejkse
Copy link
Author

vejkse commented Oct 30, 2020

Thank you! It works apparently perfectly.

kralicky pushed a commit to kralicky/fzf that referenced this issue Jun 23, 2021
Fixes junegunn#2163, though this is not a proper fix to the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants