fish: In ^r, multiline commands become multiple separate commands

[tomfitzhenry]

Steps to reproduce:

First execute a multiline command, e.g.

for i in *
    echo $i
end

Then try to retrieve that: ^r echo

Expected:

fzf to return...

for i in *
    echo $i
end

Actual:

fzf returns...
echo $i

[tomfitzhenry]

This works fine in bash (related: #146 ) and zsh (related: #142 ).

[tomfitzhenry]

The problem is that fzf's fish plugin uses history (see

fzf/shell/key-bindings.fish

Line 29 in a1db64e

history | eval (__fzfcmd) +s +m --tiebreak=index --toggle-sort=ctrl-r > $TMPDIR/fzf.result

) will print multiline commands as multiple separate commands, e.g.

$ for i in 1 2 3
    echo $i
end
1
2
3
$ history
for i in 1 2 3
echo $i
end

[junegunn]

Thanks for the report, but unfortunately I don't know how to fix this, I don't use fish, so.. Got any idea?

[tomfitzhenry]

cat ~/.config/fish/fish_history | grep '^- cmd' | cut -d ' ' -f 3- could be used as an alternative to history, but it is hacky.

This returns a string with escaped newline characters in, e.g
for i in 1 2 3 \n echo $i \n end
I need to find a way to un-escape those escaped newline charcaters, so it appears as:

for i in 1 2 3
echo $i
end

[leiserfg]

For un-escape just use printf.

[leiserfg]

In fish the $history var holds all the the commands as an array. It could be used to solve it without hack the history file.

[hauleth]

The best way to deal with that would be adding -0 flag to Fish history that would split history entries using \0 instead of newline.

[amosbird]

hmm, does fzf support multiline items now? since fish history -z will produce NUL separated strings.

[tomfitzhenry]

@amosbird sweet. https://github.com/fish-shell/fish-shell/blob/master/src/history.cpp#L1549

I'll prepare a PR.

[tomfitzhenry]

Better link: fish-shell/fish-shell@a26f68d

[amosbird]

well, please notice there is one issue #953