[fish] Support multiline commands #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix found by @amosbird at #953 (comment) closes #440
1 task
tomfitzhenry
commented
Jun 22, 2017
| @@ -44,7 +44,7 @@ function fzf_key_bindings | |||
| set -q FZF_TMUX_HEIGHT; or set FZF_TMUX_HEIGHT 40% | |||
| begin | |||
| set -lx FZF_DEFAULT_OPTS "--height $FZF_TMUX_HEIGHT $FZF_DEFAULT_OPTS --tiebreak=index --bind=ctrl-r:toggle-sort $FZF_CTRL_R_OPTS +m" | |||
| history | eval (__fzfcmd) -q '(commandline)' | read -l result | |||
| history -z | eval (__fzfcmd) --read0 -q '(commandline)' | perl -pe 'chomp if eof' | read -lz result | |||
There was a problem hiding this comment.
chomp if eof will remove the last character, which is always a newline character, when history -z is used.
Ideally we'd be able to do this with just coreutils or fish, rather than perl. Anyone know how?
There was a problem hiding this comment.
Thanks, the patch looks good to me. Just note that fzf currently prints a new line character as ?, this can be improved in the future.
Yeah, it would be nice if we don't have to use perl here, but if there's no other solution, I'm okay with it. (FWIW, head -c -1 doesn't work on macOS)
|
Merged, thanks. I'll consider changing how fzf displays new line character in the new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested to work against fish 2.4 on Debian Stretch. I will be able to test against OS X tomorrow.
Fix found by @amosbird at #953 (comment)
closes #436