Initial version of height option for Windows #1341

kelleyma49 · 2018-07-30T00:37:53Z

--height works under Windows versions that support vt100 (https://twitter.com/shanselman/status/695738082209853440).
Mouse support doesn't work.

kelleyma49 · 2018-07-30T01:56:18Z

Hmm, found an issue with the arrow keys. I need to look into why it's exiting if you bang on the up/down arrow keys.

kelleyma49 · 2018-07-30T21:01:05Z

I found another issue with calling fzf --height from within a PsReadline key handler. So I still have some work to do.

@junegunn, at least look at how I separated out the light renderer to see if you have any issues with how I implemented the separation.

junegunn · 2018-08-01T03:33:11Z

Thanks for working on this. The code separation looks good to me.

/cc @janlazo

janlazo · 2018-08-03T02:19:29Z

src/tui/light_windows.go

+func IsLightRendererSupported() bool {
+	var oldState uint32
+	// enable vt100 emulation (https://docs.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences)
+	if err := windows.GetConsoleMode(windows.Stderr, &oldState); err != nil {


Is err set here for debugging only?

janlazo · 2018-08-03T02:20:19Z

src/tui/light_windows.go

+		return false
+	}
+	canSetVt100 := windows.SetConsoleMode(windows.Stderr, windows.ENABLE_VIRTUAL_TERMINAL_PROCESSING) == nil
+	windows.SetConsoleMode(windows.Stderr, oldState)


Is this a temporary set/unset to test windows.ENABLE_VIRTUAL_TERMINAL_PROCESSING?

Yes, the goal is to check if the mode is allowed.

The other option is to explicitly check the version of WIndows is a minimum version. This is always tricky to get right across Windows 10 and server versions.

src/tui/light_windows.go

kelleyma49 · 2018-08-05T16:18:11Z

This commit is ready to be reviewed. Please review and approve #1350 as that PR fixes that people might experience more frequently under Windows.

src/tui/light.go

janlazo · 2018-12-02T02:07:21Z

Can we use Travis to test this on Windows?

kelleyma49 · 2019-04-14T01:11:57Z

@janlazo: please take a look at the latest version when you get a chance.

janlazo · 2019-04-14T21:39:19Z

@kelleyma49 Sure. Does this feature support Windows 10 only? I don't have my own Windows machine for Windows 7,8 so I can test it only in the VM.

kelleyma49 · 2019-04-15T19:50:06Z

@kelleyma49 Sure. Does this feature support Windows 10 only? I don't have my own Windows machine for Windows 7,8 so I can test it only in the VM.

It only works in Windows 10, Anniversary Update and newer (https://devblogs.microsoft.com/commandline/new-experimental-console-features/). There's code in my commit to detect if vt100 sequences are supported.

src/tui/light_windows.go

A newer version of the sys module is needed for pull request junegunn#1341

A newer version of the sys module is needed for pull request #1341

- separate Unix & Windows code into platform specific files for light renderer - height option works under WIndows platform

Fixes terminal codes from being interpreted incorrectly

src/tui/light_unix.go

wjrogers · 2020-03-05T18:21:53Z

I am testing this patch locally after merging with master @ d9c6a03. My primary use case is CTRL+R command history using PSFzf (see also kelleyma49/PSFzf#30, #1766).

PowerShell 7.0
Windows Terminal (Preview) 0.9.433.0
go 1.14
$Env:FZF_DEFAULT_OPTS="--ansi --layout=reverse --height=40%"

I had no problem building or running fzf. At first glance, the height option works correctly. I will keep using this binary and report back if I encounter anything unexpected.

--

I had some hope that these changes (and updating the sys module) would also fix #1766, but they do not. Any portion of the terminal buffer erased by fzf is not restored. I also observed some additional weird interactions w/ PSFzf, which I mention here because the PR author is also the author of PSFzf:

The prompt still gets erased after using CTRL+R, even when height is set
When there are fewer blank lines remaining in the terminal viewport than the value of height, the selected command appears at the bottom of the terminal after invoking CTRL+R

kelleyma49 · 2020-03-08T23:20:39Z

Thanks for testing this! Hopefully this will expedite the merging of this request. :)

The prompt still gets erased after using CTRL+R, even when height is set

When there are fewer blank lines remaining in the terminal viewport than the value of height, the selected command appears at the bottom of the terminal after invoking CTRL+R

I just submitted a workaround for the missing prompt issue in PSFzf. You can download a Prerelease version here: https://www.powershellgallery.com/packages/PSFzf/1.1.36-alpha.

It works around the issue by telling PsReadLine to redraw the prompt. This could be an issue if you have a slow prompt function.

Note that if you call fzf.exe directly, the screen buffer is correctly displayed after you fzf.exe, so the issues you're seeing seem to be only when fzf is executed through PSReadLine.

Separate Unix & Windows code into platform specific files for light renderer

junegunn · 2020-03-09T15:12:39Z

I'm very sorry for keeping this open for so long. I finally had a chance to test this on Windows Server 2019 and it works really well. Rebased and merged to master. Thank you very much for your contribution! 🎉

I'll be releasing a new version pretty soon.

kelleyma49 · 2020-03-09T15:44:13Z

Rebased and merged to master.

Woo hoo! 🎉

I'm very sorry for keeping this open for so long

No need to apologize. Thank you for creating such an awesome tool! 👏

junegunn added the windows label Aug 1, 2018

janlazo reviewed Aug 3, 2018

View reviewed changes

src/tui/light_windows.go Outdated Show resolved Hide resolved

janlazo reviewed Aug 3, 2018

View reviewed changes

src/tui/light_windows.go Outdated Show resolved Hide resolved

janlazo mentioned this pull request Aug 3, 2018

256 color seems not support on windows #1344

Closed

16 tasks

janlazo reviewed Aug 12, 2018

View reviewed changes

src/tui/light.go Outdated Show resolved Hide resolved

junegunn added the help-needed label Sep 12, 2018

kelleyma49 force-pushed the WindowsHeightFix branch 2 times, most recently from 6d002c5 to bf79b69 Compare April 14, 2019 01:03

junegunn mentioned this pull request Apr 17, 2019

__fzf_history__illegal option: --height #1555

Open

15 tasks

janlazo reviewed Apr 27, 2019

View reviewed changes

src/tui/light_windows.go Show resolved Hide resolved

kelleyma49 added a commit to kelleyma49/fzf that referenced this pull request May 20, 2019

Update sys module to newer version

cdcfba0

A newer version of the sys module is needed for pull request junegunn#1341

kelleyma49 mentioned this pull request May 21, 2019

Update sys module to newer version #1582

Merged

kelleyma49 added a commit to kelleyma49/fzf that referenced this pull request May 25, 2019

Update sys module to newer version

54ecb1b

A newer version of the sys module is needed for pull request junegunn#1341

junegunn pushed a commit that referenced this pull request May 26, 2019

Update sys module to newer version (#1582)

0030d18

A newer version of the sys module is needed for pull request #1341

height option works under Windows

5d2d05a

- separate Unix & Windows code into platform specific files for light renderer - height option works under WIndows platform

kelleyma49 force-pushed the WindowsHeightFix branch from bf79b69 to 5d2d05a Compare June 1, 2019 19:44

Don't reset Windows terminal before flush

a73b6b4

Fixes terminal codes from being interpreted incorrectly

junegunn mentioned this pull request Sep 26, 2019

Colors not my expected on Windows junegunn/fzf.vim#874

Open

9 tasks

janlazo mentioned this pull request Dec 16, 2019

[vim] Encode list source to codepage #1794

Merged

junegunn reviewed Dec 16, 2019

View reviewed changes

src/tui/light_unix.go Show resolved Hide resolved

KindDragon mentioned this pull request Feb 25, 2020

fzf erases scrollback buffer on Windows #1766

Open

10 tasks

kelleyma49 mentioned this pull request Mar 8, 2020

prompt gets erased when PSReadLine shortcuts are invoked kelleyma49/PSFzf#37

Closed

junegunn pushed a commit that referenced this pull request Mar 9, 2020

Make height option work under Windows (#1341)

7d5985b

Separate Unix & Windows code into platform specific files for light renderer

junegunn closed this Mar 9, 2020

junegunn removed the help-needed label Mar 9, 2020

junegunn assigned kelleyma49 Mar 9, 2020

junegunn added the feature label Mar 9, 2020

kelleyma49 deleted the WindowsHeightFix branch March 30, 2020 17:17

kelleyma49 mentioned this pull request Apr 21, 2020

Improve history navigation experience PowerShell/PSReadLine#1235

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial version of height option for Windows #1341

Initial version of height option for Windows #1341

kelleyma49 commented Jul 30, 2018

kelleyma49 commented Jul 30, 2018

kelleyma49 commented Jul 30, 2018 •

edited

junegunn commented Aug 1, 2018

janlazo Aug 3, 2018

janlazo Aug 3, 2018

kelleyma49 Feb 5, 2019

kelleyma49 commented Aug 5, 2018

janlazo commented Dec 2, 2018

kelleyma49 commented Apr 14, 2019

janlazo commented Apr 14, 2019

kelleyma49 commented Apr 15, 2019 •

edited

wjrogers commented Mar 5, 2020

kelleyma49 commented Mar 8, 2020 •

edited

junegunn commented Mar 9, 2020

kelleyma49 commented Mar 9, 2020

Initial version of height option for Windows #1341

Initial version of height option for Windows #1341

Conversation

kelleyma49 commented Jul 30, 2018

kelleyma49 commented Jul 30, 2018

kelleyma49 commented Jul 30, 2018 • edited

junegunn commented Aug 1, 2018

janlazo Aug 3, 2018

Choose a reason for hiding this comment

janlazo Aug 3, 2018

Choose a reason for hiding this comment

kelleyma49 Feb 5, 2019

Choose a reason for hiding this comment

kelleyma49 commented Aug 5, 2018

janlazo commented Dec 2, 2018

kelleyma49 commented Apr 14, 2019

janlazo commented Apr 14, 2019

kelleyma49 commented Apr 15, 2019 • edited

wjrogers commented Mar 5, 2020

kelleyma49 commented Mar 8, 2020 • edited

junegunn commented Mar 9, 2020

kelleyma49 commented Mar 9, 2020

kelleyma49 commented Jul 30, 2018 •

edited

kelleyma49 commented Apr 15, 2019 •

edited

kelleyma49 commented Mar 8, 2020 •

edited