Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$(...) calls should be quoted: "$(...)" #1667

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

$(...) calls should be quoted: "$(...)" #1667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ to install fzf.
brew install fzf

# To install useful key bindings and fuzzy completion:
$(brew --prefix)/opt/fzf/install
"$(brew --prefix)/opt/fzf/install"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about this one 🤔

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The brew prefix path might include spaces, so strictly speaking it must be quoted (no one ever uses a non-default brew prefix, so yeah..)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

```

fzf is also available [via MacPorts][portfile]: `sudo port install fzf`
Expand Down Expand Up @@ -244,7 +244,7 @@ files excluding hidden ones. (You can override the default command with
`FZF_DEFAULT_COMMAND`)

```sh
vim $(fzf)
vim "$(fzf)"
```

#### Using the finder
Expand All @@ -262,14 +262,14 @@ fzf by default starts in fullscreen mode, but you can make it start below the
cursor with `--height` option.

```sh
vim $(fzf --height 40%)
vim "$(fzf --height 40%)"
```

Also check out `--reverse` and `--layout` options if you prefer
"top-down" layout instead of the default "bottom-up" layout.

```sh
vim $(fzf --height 40% --reverse)
vim "$(fzf --height 40% --reverse)"
```

You can add these options to `$FZF_DEFAULT_OPTS` so that they're applied by
Expand Down