Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bash] Put C-t items at point in vi mode #1876

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Feb 16, 2020

Be consistent with emacs mode and put the items at the point vs. the end
of the command line.

@junegunn
Copy link
Owner

I really like this approach, thanks. I'm a bit concerned with these new bindings though.

bind -m vi-command '"\C-e": emacs-editing-mode'
bind -m vi-insert '"\C-e": emacs-editing-mode'

CTRL-E is such an "accessible", easy key chord, that I can imagine people already have their own bindings on it. How about if we choose some esoteric key sequence that is less likely to conflict? We've been using CTRL-X CTRL-E, so it's a good candidate. What do you think?

@jablko
Copy link
Contributor Author

jablko commented Feb 20, 2020

How about C-z like in Viper or Evil?

@jablko jablko force-pushed the patch-4 branch 3 times, most recently from 076d273 to 6f8d960 Compare February 20, 2020 23:36
Be consistent with emacs mode and put the items at the point vs. the end
of the command line.
@junegunn junegunn merged commit 9c293bb into junegunn:master Feb 21, 2020
@junegunn
Copy link
Owner

Superb, thanks!

shibli049 added a commit to shibli049/fzf that referenced this pull request Feb 22, 2020
[bash] Put C-t items at point in vi mode (junegunn#1876)
junegunn added a commit to junegunn/fzf-git.sh that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants