Use tmux shell-command

[jablko]

Since Tmux.new(shell) (:bash, :zsh, :fish) are just indexes to Shell.send(shell),

fzf/test/test_go.rb

Lines 89 to 90 in 15e2952

	def initialize(shell = :bash)
	@win = go(%W[new-window -d -P -F #I #{Shell.send(shell)}]).first

• fzf/test/test_go.rb

  Lines 55 to 63 in 15e2952

  	def bash
  	@bash ||=
  	begin
  	bashrc = '/tmp/fzf.bash'
  	File.open(bashrc, 'w') do |f|
  	f.puts(ERB.new(TEMPLATE).result(binding))
  	end
  	"bash --rcfile #{bashrc}"

• fzf/test/test_go.rb

  Lines 67 to 76 in 15e2952

  	def zsh
  	@zsh ||=
  	begin
  	zdotdir = '/tmp/fzf-zsh'
  	FileUtils.rm_rf(zdotdir)
  	FileUtils.mkdir_p(zdotdir)
  	File.open("#{zdotdir}/.zshrc", 'w') do |f|
  	f.puts(ERB.new(TEMPLATE).result(binding))
  	end
  	"ZDOTDIR=#{zdotdir} zsh"

• fzf/test/test_go.rb

  Lines 80 to 81 in 15e2952

  	def fish
  	UNSETS.map { |v| v + '= ' }.join + 'fish'

what do you think about simply passing the command to Tmux.new instead?
https://github.com/jablko/fzf/blob/21afe1c09bd7e6775503195a1aed00eb3b40e0fc/test/test_go.rb#L56-L57

• https://github.com/jablko/fzf/blob/21afe1c09bd7e6775503195a1aed00eb3b40e0fc/test/test_go.rb#L2056-L2063
• https://github.com/jablko/fzf/blob/21afe1c09bd7e6775503195a1aed00eb3b40e0fc/test/test_go.rb#L2094-L2103
• https://github.com/jablko/fzf/blob/21afe1c09bd7e6775503195a1aed00eb3b40e0fc/test/test_go.rb#L2118

This was originally part of #1900

[junegunn]

Thanks but why don't we open a separate pull request for Rubocop changes you made first? They are not related to what you're proposing here. That way, it would be easier to discuss different concerns (#1900 #1962 #1964).

[jablko]

👍 Thank you for reviewing these changes. I've opened a PR for just the RuboCop changes: #1967