Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent kill behaviour #1988

Closed
wants to merge 1 commit into from
Closed

Consistent kill behaviour #1988

wants to merge 1 commit into from

Conversation

hellricer
Copy link

This addresses issue #385 .

@hellricer hellricer force-pushed the consistent-kill branch 2 times, most recently from 8a3b171 to 00d242d Compare April 17, 2020 11:19
@hellricer hellricer changed the title Consistent kill Consistent kill behaviour Apr 17, 2020
@junegunn
Copy link
Owner

Thanks, but it's a 6+-year-old behavior and we don't have a consensus if we should do this or not. I'll leave this open.

@junegunn
Copy link
Owner

A nice middle ground would be to support both cases, i.e. kill <tab> and kill foo**<tab>.

junegunn added a commit that referenced this pull request Apr 17, 2020
@junegunn
[completion] Make kill completion more consistent with the others
1007a98 
Support both ordinary completion trigger and empty trigger

    kill <tab>
    kill foo**<tab>

Close #1988
Close #385
junegunn added a commit that referenced this pull request Apr 17, 2020
@junegunn
[completion] Make kill completion more consistent with the others
6e20c72 
Support both ordinary completion trigger and empty trigger

    kill <tab>
    kill foo**<tab>

Close #1988
Close #385
@junegunn junegunn closed this in c329279 Apr 17, 2020
@hellricer
Copy link
Author

Awesome! Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hellricer @junegunn