Add more tests of placeholder flags and simplify its logic #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests some reasonable commands in fzf's templates (for commands, previews, rebinds etc.), how are those commands escaped (backslashes, double quotes), and documents if the output is executable in cmd.exe. Both on Unix and Windows.
Adds tests and bit of docs for the curly brackets placeholders in fzf's template strings. Also tests the "placeholder" regex.
Replacing placeholders in templates is already tested, this adds tests that focus more on the parameters of placeholders - e.g. flags, token ranges. There is at least one test for each flag, not all combinations are tested though.
Quotes and a typo.
…g source file This is minor refactoring, and also the function's test was made crossplatform.
Should be equivalent to the original, but has simpler structure.
|
|
junegunn
requested changes
Oct 12, 2021
|
Merged, thanks! |
|
Cool, thanks for merging. |
Closed
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is some work I have done while playing with #2609. No changes though, just tests, refactoring and bit of docs.
Notable:
replacePlaceholderfunction, that seemed rather difficult to understand/edit at first. I have got tests before I touched anything; all the logic should be equivalent.