Add missing color specifications #3519
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vantaboard
changed the title
junegunn
reviewed
Dec 10, 2023
| ``` | ||
|
|
||
|  | ||
|
|
||
| ```sh | ||
| # morhetz/gruvbox | ||
| export FZF_DEFAULT_OPTS='--color=bg+:#3c3836,bg:#32302f,spinner:#fb4934,hl:#928374,fg:#ebdbb2,header:#928374,info:#8ec07c,pointer:#fb4934,marker:#fb4934,fg+:#ebdbb2,prompt:#fb4934,hl+:#fb4934' | ||
| export FZF_DEFAULT_OPTS='--color=fg+:#3c3836,preview-bg:#d5c4a1,info:#427b58,spinner:#9d0006,prompt:#9d0006,fg:#3c3836,header:#928374,marker:#9d0006,hl+:#9d0006,query:#928374,hl:#928374,pointer:#9d0006' |
There was a problem hiding this comment.
The colors doesn't look right.
Before:
After:
There was a problem hiding this comment.
Which theme were you trying?
junegunn
reviewed
Dec 10, 2023
| ```vim | ||
| let g:fzf_colors = | ||
| \ { 'fg': ['fg', 'Normal'], | ||
| \ 'bg': ['bg', 'Normal'], | ||
| \ 'preview-fg': ['bg', 'Normal'], |
There was a problem hiding this comment.
preview-fg defaults to fg, so this line shouldn't be necessary. And the first argument bg doesn't seem correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some color specifications were missing which introduced terminal scheme weirdness when exporting with
Before and after with junegunn/seoul256.vim (dark):
Before and after with junegunn/seoul256.vim (light):
The following changes resolve this:
commit e4eb64f82a88888729c0624bf5790cd29bea86b2 Author: Brighten Tompkins <brighten@parseceducation.com> Date: Wed Nov 29 08:47:14 2023 -0800 [advanced-docs] add missing color specs diff --git a/ADVANCED.md b/ADVANCED.md index 661bac1..00311fb 100644 --- a/ADVANCED.md +++ b/ADVANCED.md @@ -583,6 +583,7 @@ Here is an example. Add this to your Vim configuration file. let g:fzf_colors = \ { 'fg': ['fg', 'Normal'], \ 'bg': ['bg', 'Normal'], + \ 'preview-fg': ['bg', 'Normal'], \ 'preview-bg': ['bg', 'NormalFloat'], \ 'hl': ['fg', 'Comment'], \ 'fg+': ['fg', 'CursorLine', 'CursorColumn', 'Normal'], @@ -594,6 +595,9 @@ let g:fzf_colors = \ 'pointer': ['fg', 'Exception'], \ 'marker': ['fg', 'Keyword'], \ 'spinner': ['fg', 'Label'], + \ 'gutter': ['bg', 'SignColumn'], + \ 'query': ['fg', 'Comment'], + \ 'disabled': ['fg', 'Ignore'], \ 'header': ['fg', 'Comment'] }Additionally, I added an example for Lua configurations and updated the
FZF_DEFAULT_OPTSvariable forjunegunn/seoul256.vim,morhetz/gruvbox,arcticicestudio/nord-vim, andtomasr/molokai.