Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: header-click event for reporting clicks within header #3768

Merged
merged 8 commits into from
May 5, 2024
Merged

feature: header-click event for reporting clicks within header #3768

merged 8 commits into from
May 5, 2024

Commits on May 4, 2024

  1. Add header-click event for reporting clicks within header. 

    Sets $FZF_HEADERCLICK_LINE and $FZF_HEADERCLICK_COLUMN env vars with
coordinates of last click inside and relative to the header and fires
header-click event.
    @kuremu
    kuremu committed May 4, 2024
    Configuration menu
    Copy the full SHA
    0b68c1a View commit details
    Browse the repository at this point in the history

  2. Fixed formatting for header-click

    @kuremu
    kuremu committed May 4, 2024
    Configuration menu
    Copy the full SHA
    29a4018 View commit details
    Browse the repository at this point in the history

  3. manpage entry for header-click

    @kuremu
    kuremu committed May 4, 2024
    Configuration menu
    Copy the full SHA
    c587f4a View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Renamed header-click to click-header

    @kuremu
    kuremu committed May 5, 2024
    Configuration menu
    Copy the full SHA
    b7dac9e View commit details
    Browse the repository at this point in the history

  2. Changed click-header env vars to 1-indexed

    @kuremu
    kuremu committed May 5, 2024
    Configuration menu
    Copy the full SHA
    b522297 View commit details
    Browse the repository at this point in the history

  3. Now resetting FZF_CLICK_HEADER_* env vars after firing click-header

    @kuremu
    kuremu committed May 5, 2024
    Configuration menu
    Copy the full SHA
    1c887ca View commit details
    Browse the repository at this point in the history

  4. Update man/man1/fzf.1

    @junegunn
    junegunn committed May 5, 2024
    Configuration menu
    Copy the full SHA
    b6ead62 View commit details
    Browse the repository at this point in the history

  5. Always export variables 

    After some testing, I decided that we should not reset the variables.
Because if we do that, the information becomes unavailable to the
preview process as it runs asynchronously in a different goroutine.

  fzf --header-lines=2 --bind 'click-header:transform-prompt(printf ${FZF_CLICK_HEADER_LINE}x${FZF_CLICK_HEADER_COLUMN})+preview(env | grep FZF)'
    @junegunn
    junegunn committed May 5, 2024
    Configuration menu
    Copy the full SHA
    354b8b2 View commit details
    Browse the repository at this point in the history