":GV": consider opening tab *before* current tab

[justinmk]

In fugitive's :Gstatus window, cvc/cva opens its tab before the current tab, so that closing the tab returns to the correct original tab. When I q out of a :GV tab, it returns to the wrong tab. Any opposition to following fugitive's behavior?

[junegunn]

No objections. I just wasn't aware of the inconvenience since I rarely use tabs.

[junegunn]

Fixed it. One thing I noticed though is that O mapping from fugitive in git buffer opens a new tab after the current split. Seems a bit inconsistent.

[justinmk]

Good point. I imagine the justification is that cvc and cva are intended as "short-lived" tabs, for which the common case is that the user closes them and most likely wants to return to the original tab. I'd say similar logic applies to :GV. And I'd even say it applies to fugitive's O in most cases...

But since fugitive's O is documented as :Gtabedit (which surely must match the behavior of Vim's :tabedit), maybe tpope didn't want to bother explaining the difference. And after this insanity I doubt he would entertain changing the existing behavior.

Sadly this means I can't drop the idea that Vim needs a "previous tab" feature.

Also, thanks!

[junegunn]

after this insanity

Haha, that's crazy.

I also applied the change to the neovim plugin of fzf.