Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatal: not a git repository, when using 'dir' with the existent directory #766

Closed
3 tasks done
igorepst opened this issue Jun 13, 2018 · 1 comment
Closed
3 tasks done
Assignees

Comments

@igorepst
Copy link

Hello. I'm trying to install fzf executable to /opt/fzf to make it shared between the users.
Like so:
Plug 'junegunn/fzf', { 'dir': '/opt/fzf', 'do': './install --all' }
Beforehand I created the /opt/fzf directory and did chown on it (as only root may write by default to /opt)
However, I got:

x fzf:
    fatal: not a git repository (or any of the parent directories): .git
    PlugClean required.

If I add another level to 'dir', like opt/fzf/fzf, effectively pointing to non-existent directory, it works. So, my question is whether it is possible to use an existent empty directory.
Thanks

  • Type:
    • Question
  • OS:
    • Linux
  • Vim:
    • Terminal Vim
@igorepst igorepst changed the title fatal: not a git repository, when using 'dir' at /opt fatal: not a git repository, when using 'dir' with the existent directory Jun 13, 2018
@junegunn
Copy link
Owner

junegunn commented Aug 8, 2018

This is currently not supported (checked for safety), but I think it makes sense to allow it when the directory is completely empty.

@junegunn junegunn self-assigned this Aug 8, 2018
junegunn added a commit that referenced this issue Aug 8, 2018
junegunn added a commit that referenced this issue Sep 12, 2018
Close #766

We can rely on git to check if the destination directory is empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants