Fix chcp parsing for the current codepage #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relying on delimiters or token positions is fragile. Last value of 'chcp' output is always a number.
11 tasks
|
Thanks. Maybe I should port this to fzf? |
|
Yes. |
junegunn
added a commit
to junegunn/fzf
that referenced
this pull request
Oct 8, 2019
|
The parsing doesn't take into account codepage values mixed with non-numeric characters. Need sed or some cmd.exe alternative to strip out non-numeric characters after the for-loops. I'll open a PR later for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #874
Fix #884
Fix #885
Related #886
cc @gh4w
Patch is adapted from stackoverflow answer, https://stackoverflow.com/a/10535753