Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #884
sed
is now required to parsechcp
output. Vim can be used instead via separate childsystem
call but doing it pers:system
makes Windows slower.chcp
parsing is fragile because of the system locale. There's no convenient way to parse out the codepage value without regex just by relying on cmd.exe builtins and default binaries inPATH
.If this still doesn't work, users will have to get by with ascii output only (no readable unicode symbols from console) because this is a OS problem. This applies to fzf as well because the chcp code orignated from fzf Vim plugin was meant for UTF-8 characters.
Powershell builtins could be used as an alternative to sed but using powershell on non-powershell
&shell
slows downs:system
.