Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: additional steps for private submodules #9

Closed
AchrafAsh opened this issue Jan 1, 2023 · 1 comment 路 Fixed by #11
Closed

Docs: additional steps for private submodules #9

AchrafAsh opened this issue Jan 1, 2023 · 1 comment 路 Fixed by #11
Labels
documentation Improvements or additions to documentation

Comments

@AchrafAsh
Copy link
Contributor

Thank you @junhoyeo for this awesome tool! 馃檹

It just took me a while before understanding that in order to work (at least with private submodules) one has to:

  1. generate an access token,
  2. add it as an environment variable in Vercel (GITHUB_TOKEN).

I can open a PR to add the steps above in the README if you want.
@junhoyeo
Copy link
Owner

junhoyeo commented Jan 1, 2023

@AchrafAsh Of course, you are welcome to create a PR with a detailed exploration. It would sure be helpful for newbies!

@junhoyeo junhoyeo added the documentation Improvements or additions to documentation label Jan 1, 2023
@junhoyeo junhoyeo mentioned this issue Jan 1, 2023
Merged
junhoyeo added a commit that referenced this issue Jan 1, 2023
@junhoyeo
[docs] Update README.md
abe8c1f 
Typo in #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] Add steps to set the GitHub Token AchrafAsh/vercel-submodules
2 participants
@junhoyeo @AchrafAsh