[cli] Adopt GitHub fine-graned token #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super! I'm out right now, will check in a few hours! |
junhoyeo
reviewed
Dec 21, 2022
| @@ -6,23 +6,24 @@ import * as zx from 'zx'; | |||
| import { insideDir } from '../utils/filesystem.js'; | |||
| import { Submodule } from '../utils/submodules.js'; | |||
|
|
|||
| const convertToAuthURL = (url: string, githubToken: string): string => { | |||
| const convertToAuthURL = (url: string, githubToken: string, isFineGrained: boolean): string => { | |||
There was a problem hiding this comment.
Nice! Would love to rewrite this by making the params into an single object soon.
junhoyeo
changed the title
junhoyeo
changed the title
|
@harumaxy Just released 1.0.7! Sorry to keep you waiting. 馃殌 |
junhoyeo
added a commit
that referenced
this pull request
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm also using vercel and trying to include git submodule in build time.
This script is using classic Personal Access Token, but I wanna use new fine-graned PAT because I work for a company and it's more suitable for access management for organization private repo.
It seems to need some fix to URL to use fine-grained token. (like this)
So I added
--fg-tokenflag, and fix code to addoauth2:before token in Github URL if fine-grained token is given.I would appreciate if you could review 馃檹.