Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all Color constructors #30

Closed
jmborer opened this issue May 31, 2019 · 14 comments
Closed

Support all Color constructors #30

jmborer opened this issue May 31, 2019 · 14 comments
Assignees

Comments

@jmborer
Copy link

jmborer commented May 31, 2019

Please implement all Color constructors. Not all of us use R,G,B.

@junichi11 junichi11 self-assigned this May 31, 2019
@junichi11
Copy link
Owner

Not all of us use R,G,B.

Unnecessary words.

@jmborer
Copy link
Author

jmborer commented May 31, 2019

I hope you don't mean it disrespecful, since my comment is based on facts not a personal judgement... In my team, we use mainly floats, hex and HSL color declarations. They are missing currently in your great plugin. This is also the reason I proposed to help.

@junichi11
Copy link
Owner

I'm saying that you need not say "Not all of us use R,G,B.". The vice versa is also the same thing. I feel you are complaining about missing patterns. Such the comment may make someone uncomfortable. So unnecessary words.

@jmborer
Copy link
Author

jmborer commented May 31, 2019

Hmm. I think we are misunderstanding each other here. My comment was not meant to be rude in any way. As the plugin essentially support RGB declared color and that we don't such declarations, I was just saying that it would me maybe more useful then you may think to support the "missing" color constructors.

@junichi11
Copy link
Owner

Yes, so you should not write such a comment to avoid misunderstanding. That's that :)
I'm going to implement them later. Thanks.

@junichi11
Copy link
Owner

junichi11 commented Jun 5, 2019

Done. https://github.com/junichi11/netbeans-color-codes-preview/releases/tag/v0.12.3

If you find some problems, please report them to Issues as new issues.

If there is no problem, I'll upload the new version to Plugin Portal.

NOTE

  • Won't support new Color(float, float, float) without f e.g. new Color(0.5f, 0.2f, 0);

@junichi11
Copy link
Owner

@jmborer Could you please try using it? Please let me know whether it works fine if possible. After that, I'm going to upload the nbm to Plugin Portal. Thanks.

@jmborer
Copy link
Author

jmborer commented Jun 6, 2019

Shall I build it from sources?

@junichi11
Copy link
Owner

Need not to do that. As wrote the above, you can use https://github.com/junichi11/netbeans-color-codes-preview/releases/tag/v0.12.3.

@jmborer
Copy link
Author

jmborer commented Jun 6, 2019

I'll test.

@jmborer
Copy link
Author

jmborer commented Jun 6, 2019

My corporate proxy doesn't allow me to download nbm from github. I'll have to compile it myself.

@junichi11
Copy link
Owner

I see. OK.

@jmborer
Copy link
Author

jmborer commented Jun 6, 2019 via email

@junichi11
Copy link
Owner

Thank you! I'll upload it to PP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants