New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all Color constructors #30
Comments
Unnecessary words. |
I hope you don't mean it disrespecful, since my comment is based on facts not a personal judgement... In my team, we use mainly floats, hex and HSL color declarations. They are missing currently in your great plugin. This is also the reason I proposed to help. |
I'm saying that you need not say "Not all of us use R,G,B.". The vice versa is also the same thing. I feel you are complaining about missing patterns. Such the comment may make someone uncomfortable. So unnecessary words. |
Hmm. I think we are misunderstanding each other here. My comment was not meant to be rude in any way. As the plugin essentially support RGB declared color and that we don't such declarations, I was just saying that it would me maybe more useful then you may think to support the "missing" color constructors. |
Yes, so you should not write such a comment to avoid misunderstanding. That's that :) |
Done. https://github.com/junichi11/netbeans-color-codes-preview/releases/tag/v0.12.3 If you find some problems, please report them to Issues as new issues. If there is no problem, I'll upload the new version to Plugin Portal. NOTE
|
@jmborer Could you please try using it? Please let me know whether it works fine if possible. After that, I'm going to upload the nbm to Plugin Portal. Thanks. |
Shall I build it from sources? |
Need not to do that. As wrote the above, you can use https://github.com/junichi11/netbeans-color-codes-preview/releases/tag/v0.12.3. |
I'll test. |
My corporate proxy doesn't allow me to download nbm from github. I'll have to compile it myself. |
I see. OK. |
After a few tests, it looks good.
…On Thu, Jun 6, 2019 at 1:08 PM Junichi Yamamoto ***@***.***> wrote:
I see. OK.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30?email_source=notifications&email_token=ABSND5W2IJR2N2C4MQGQ623PZED5VA5CNFSM4HRVPOZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXCY3BA#issuecomment-499486084>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABSND5UQ3PAAOWTW5H667A3PZED5VANCNFSM4HRVPOZQ>
.
|
Thank you! I'll upload it to PP. |
Please implement all Color constructors. Not all of us use R,G,B.
The text was updated successfully, but these errors were encountered: