Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore.io/api/list change breaks available ignore types #5

Closed
baykant opened this issue Feb 12, 2017 · 5 comments
Closed

gitignore.io/api/list change breaks available ignore types #5

baykant opened this issue Feb 12, 2017 · 5 comments
Assignees
Labels
Milestone

Comments

@baykant
Copy link

baykant commented Feb 12, 2017

Hi,

I am using this plugin in netbeans 8.2 (used it for 8.1, 8 and previous versions also for more than 1 year)

Recently gitignore.io/api/list output format changed and comma (,) from the line ends removed. The available type list could not split output correctly
Current gitignore.io/api/list output sample below:
momentics,monodevelop,nanoc,ncrunch,nesc
netbeans,nette,nim,ninja,node

The result of this output populates list with combined type list like nescnetbeans
After I created an issue for this change in https://github.com/joeblau/gitignore.io
( toptal/gitignore.io#299 ) I got a response that now there are 2 more output types, lines and json format.

I guess GITIGNORE_API_LIST and / or splitGitIgnores() method in GitIgnoreListPanel.java may be updated for fixing this issue.

sample selection dialog screenshot is attached.
gitignore io available list_044

@junichi11 junichi11 self-assigned this Feb 12, 2017
@junichi11
Copy link
Owner

Thanks for reporting it! I'll fix it.

@junichi11 junichi11 added this to the 0.3.0 milestone Feb 13, 2017
junichi11 added a commit that referenced this issue Feb 13, 2017
@junichi11
Copy link
Owner

Fixed. Please try to use the new version (0.3.0).

https://github.com/junichi11/netbeans-gitignore-io-plugin/releases/tag/v0.3.0

Thanks.

@junichi11
Copy link
Owner

@baykant BTW, if you tried it, please let me know. Because I would like to upload the nbm to the Plugin Portal if there are no problems.

Thanks.

@baykant
Copy link
Author

baykant commented Feb 13, 2017

@junichi11 I just downloaded and tried. Working without any issue for now. Thanks for the update.

@junichi11
Copy link
Owner

@baykant Thank you for the quick testing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants