Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialSSH not closing SSH session when netconf fails. #86

Closed
bsherwood12 opened this issue May 17, 2019 · 1 comment · Fixed by #87
Closed

DialSSH not closing SSH session when netconf fails. #86

bsherwood12 opened this issue May 17, 2019 · 1 comment · Fixed by #87

Comments

@bsherwood12
Copy link

DialSSH (https://github.com/Juniper/go-netconf/blob/master/netconf/transport_ssh.go#L111)
Does not close the ssh session if the netconf session fails.

DialSSH needs to close the ssh session if the netconf session fails, or handle this situation in some way that does not cause a hung ssh session.

@pplavetzki
Copy link
Collaborator

@bsherwood12 I will create a pull request referencing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants