Skip to content

Commit

Permalink
Rename label "merge-ready" to "full-build" (#679 / #682)
Browse files Browse the repository at this point in the history
Switching from the reduced, faster build to the full build of all
Java/OS/etc combinations requires adding a specific label to the PR.
It was called "merge-ready", which marks the PR as being ready to be
merged once the build is green, but that is (at least) occasionally
not the case.

To avoid confusion, we rename the label to the less leading name
"full-build".

Closes: #679
PR: #682
  • Loading branch information
nipafx committed Nov 10, 2022
1 parent ebe3182 commit 839be6a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Expand Up @@ -108,9 +108,9 @@ jobs:
# Our full integration job, which will build for a matrix out of our supported
# Java versions, operating systems, modular or not, and various JUnit versions.
# This build is executed on all tags and the default branch. Furthermore, we will
# also execute this for pull requests with the label `merge-ready`.
# also execute this for pull requests with the label `full-build`.
full-featured:
if: (contains(github.event.pull_request.labels.*.name, 'merge-ready') || !github.event.pull_request)
if: (contains(github.event.pull_request.labels.*.name, 'full-build') || !github.event.pull_request)
needs: basic
runs-on: ${{ matrix.os }}-latest
timeout-minutes: 15
Expand Down Expand Up @@ -139,7 +139,7 @@ jobs:
# Furthermore, we also would love to see our build working with the latest Gradle version.
# As those builds might fail, they are allowed to fail, and should not prevent merges.
experimental:
if: (contains(github.event.pull_request.labels.*.name, 'merge-ready') || !github.event.pull_request)
if: (contains(github.event.pull_request.labels.*.name, 'full-build') || !github.event.pull_request)
needs: full-featured
runs-on: ${{ matrix.os }}-latest
continue-on-error: true
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Expand Up @@ -391,7 +391,7 @@ To enforce the [branching strategy](#branching-strategy) pull requests from `mai
### Full Testing

In order to minimize the delay between a push and feedback, the default build is only run on a small subset of all possible builds (which include different operating system, Java versions and so on).
Once a pull request is ready to be merged, a maintainer needs to apply the _merge-ready_ label to trigger a full build.
To get more wider feedback, for example once a pull request is ready to be merged, a maintainer needs to apply the _full-build_ label to trigger just that.

### Merging

Expand Down

0 comments on commit 839be6a

Please sign in to comment.