Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade JUnit version to 5.4.2 #209

Closed
Bukama opened this issue Mar 29, 2020 · 1 comment · Fixed by #210
Closed

Upgrade JUnit version to 5.4.2 #209

Bukama opened this issue Mar 29, 2020 · 1 comment · Fixed by #210
Labels
⚙️ component: Pioneer Issues about Pioneer own things (e.g. utils) 🚦 status: in progress 🏗️ type: task

Comments

@Bukama
Copy link
Member

Bukama commented Mar 29, 2020

We still use JUnit Jupiter 5.3.x. Some days ago 5.6.1 was released.

To be able to resolve #6 we need to upgrade to at least 5.4.2, but I suggest to upgrade to the lastest available version.

Jupiter 5.6.1 | Vintage 5.6.1 | Platform | 1.6.1 (as of 2020-03-29 16:20 CEST)
Bukama added a commit to Bukama/junit-pioneer that referenced this issue Mar 29, 2020
@Bukama
Update JUnit and test frameworks dependencies
2aaf13c 
fixes junit-pioneer#209
@Bukama Bukama mentioned this issue Mar 29, 2020
Merged
@nipafx nipafx added the ⚙️ component: Pioneer Issues about Pioneer own things (e.g. utils) label Mar 30, 2020
@nipafx
Copy link
Member

nipafx commented Mar 30, 2020

Unless there's a specific need for 5.6.1, we should go with 5.4.2. As the README says:

Pioneer always depends on the lowest JUnit 5 version that supports its feature set

The intention is not to force users into a higher version than we require.

@Bukama Bukama changed the title Upgrade JUnit version to 5.6. Upgrade JUnit version to 5.4.2 Mar 31, 2020
nipafx pushed a commit to Bukama/junit-pioneer that referenced this issue Mar 31, 2020
@Bukama
Update JUnit and test frameworks dependencies
efeea1c 
fixes junit-pioneer#209
nipafx pushed a commit that referenced this issue Mar 31, 2020
@Bukama
Update JUnit and test frameworks dependencies
936aac6 
In order to remove our use of internal APIs (see #6), we need to
upgrade our dependency on JUnit to at least 5.4.2.

PR: #210
Closes: #209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚙️ component: Pioneer Issues about Pioneer own things (e.g. utils) 🚦 status: in progress 🏗️ type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update JUnit and test frameworks dependencies Bukama/junit-pioneer
3 participants
@Bukama @nipafx @aepfli