Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Pioneers assertions #298

Closed
Michael1993 opened this issue Jul 14, 2020 · 4 comments · Fixed by #305
Closed

Improvements to Pioneers assertions #298

Michael1993 opened this issue Jul 14, 2020 · 4 comments · Fixed by #305
Assignees
@Michael1993
Labels
⚙️ component: Pioneer Issues about Pioneer own things (e.g. utils) 🚦 status: in progress 📖 theme: cleanup 🏗️ type: enhancement
Projects
Exploring Io

Comments

@Michael1993
Copy link
Member

We decided on stream that the current state of #245 is good enough to merge but there is room for improvement.
Some starting ideas:

  • separating ExecutionResultAssert into test case assertions, report entry assertions and test suite assertions.
  • reconsider the names of the interfaces, e.g.: ExecutionResultAssert could be SingleTestAssert, TestCaseAssert could be StartedTestAssert, etc.
Bukama pushed a commit that referenced this issue Jul 14, 2020
@Michael1993
Create assertions for Pioneer (#232 / #245)
0691375 
In 0b79db8 (#6 / #218), we moved all assertion-like methods onto the
`ExecutionResults` class even though that wasn't a good fit. The
intention was to collect all such methods to then more easily replace
them with proper AssertJ-like assertions that we needed to write
ourselves.

This change implements these methods. The API is pretty good already,
but we expect that after using it for a while the experience with it
as well as new use cases may lead to further changes (see #298).

Closes: #232
PR: #245
@nipafx
Copy link
Member

nipafx commented Jul 14, 2020

Please remember to add your contribution of the assertions to the README. :)

@Bukama
Copy link
Member

Bukama commented Jul 15, 2020

I'm open for improvements

@Michael1993
Copy link
Member Author

Probably should expose published report entries and thrown exceptions to miscellaneous assertions.

@Michael1993 Michael1993 mentioned this issue Jul 31, 2020
Merged
11 tasks
@Michael1993
Copy link
Member Author

After working on the concurrency PR, I realised that adding thrown exceptions from indirectly executed tests makes debugging failing assertions a lot easier, so I added that too

@Bukama Bukama added this to the Exploring Io milestone Oct 25, 2020
@nipafx nipafx removed this from the Exploring Io milestone Oct 27, 2020
@nipafx nipafx added this to To do in Exploring Io Oct 27, 2020
@Bukama Bukama moved this from To do to In progress in Exploring Io Oct 27, 2020
Exploring Io automation moved this from In progress to Done Oct 30, 2020
Bukama pushed a commit that referenced this issue Oct 30, 2020
@Michael1993
Improve Pioneer assertions (#298 / #305)
3c2a9d5 
This PR improves the Pioneer assertions turning ExecutionResultAssert
into multiple different assertions to provide more precise assertions,
e.g. to verify published ReportEntries or exceptions.

Also there are more precise assertions where exactly one result is expected.

closes #298
PR: #305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Michael1993 Michael1993

Labels
⚙️ component: Pioneer Issues about Pioneer own things (e.g. utils) 🚦 status: in progress 📖 theme: cleanup 🏗️ type: enhancement
Projects
No open projects
Exploring Io
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvements to Pioneer assertions
3 participants
@Michael1993 @Bukama @nipafx