Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move StopwatchExtension to pioneer #38

Closed
smoyer64 opened this issue Mar 14, 2017 · 3 comments · Fixed by #182
Closed

Move StopwatchExtension to pioneer #38

smoyer64 opened this issue Mar 14, 2017 · 3 comments · Fixed by #182

Comments

@smoyer64
Copy link
Member

From the example code in the JUnit 5 documentation - https://github.com/selesy/junit5/blob/issues/343-document-testrule-compatibility/documentation/src/test/java/example/testrule/StopwatchExtension.java

@Bukama
Copy link
Member

Bukama commented Feb 15, 2020

As I'm struggeling at the same as when I tried to implement the @Issue annotation I'll post a link to the branch here and if anyone want's to adapt the current state feel free to do so.

https://github.com/Bukama/junit-pioneer/tree/stopwatch

My problems are:

  1. Entering the extension context inside a test to verify if the values of another store are beeing stored
  2. Verifiy if the TestReporter prints the information correct inside the resulting XML

I checked via a System.out that the extension is executed, but I don't find a way to enter the context from a test class. I tried to pass it via n paramter, but this leads to an error, that there's no ParameterResolver for the ExtensionContext class.

I also tried to pass an TestReporter parameter. This can be resolved, but the interface only has methods to publish something via the reporter, but not to check if it contains the right data.

In both cases there are no further explanations in the Jupiter documentation.

Maybe you find a way to verify the execution of the extension.

@Bukama
Copy link
Member

Bukama commented Apr 26, 2020

I opened a PR, but @Michael1993 wants to work on it before it gets merged. So I assign this bishue to him.

@Bukama Bukama added 🚦 status: reviewing 📖 theme: extensions and removed ⚙️ component: Jupiter Issues coming from (internal/official) Jupiter features etc. 🏗️ type: enhancement labels May 9, 2020
@Michael1993 Michael1993 removed their assignment Aug 5, 2020
@Michael1993
Copy link
Member

The PR looks good (to me)!

@Bukama Bukama self-assigned this Aug 5, 2020
@Bukama Bukama added this to the Exploring Io milestone Oct 25, 2020
@nipafx nipafx removed this from the Exploring Io milestone Oct 27, 2020
@nipafx nipafx added this to To do in Exploring Io Oct 27, 2020
@Bukama Bukama moved this from To do to In progress in Exploring Io Oct 27, 2020
Exploring Io automation moved this from In progress to Done Dec 7, 2020
Michael1993 pushed a commit that referenced this issue Dec 7, 2020
Implement the Stopwatch extension (#38 / #182)

This PR moves the Stopwatch extension from JUnit Jupiter
examples to JUnit Pioneer. The extension measures the
elapsed time of each test (which is executed with the
extension) and publishes the the result as a ReportEntry.

closes: #38 
PR: #182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants